fix(cwl): Rename LiveTail metric definitions #932
Conversation
| "type": "result" | ||
| }, | ||
| { | ||
| "type": "sessionAlreadyStarted", |
There was a problem hiding this comment.
Just FYI: if "sessionAlreadyStarted" is a kind of failure, it's strongly recommended to simply throw an exception and let telemetry.xx.run(...) automatically set result=Failed and reason=<code> where <code> is the error code. https://github.com/aws/aws-toolkit-vscode/blob/016e478399f4e4e050e5e644c98c96297930e8ad/packages/core/src/shared/errors.ts#L144
That has other benefits: all failures can be captured in dashboards/queries easily, without needing to know specific, special fields such as this one.
However, if this is only an informational field and doesn't represent a failure or cancellation, then the above doesn't apply.
There was a problem hiding this comment.
We don't consider this to be a failure case. This would be an informational field. The telemetry.xx.run(...) will not raise an exception.
## Problem Updating telemetry to accommodate changes in aws/aws-toolkit-common#932 ## Solution Update package version for telemetry. Add validation on the LogStreamFilter submenu's response for filter type. This is needed to allow the type returned from the LogStreamFilterSubmenu to be convertible to the type in the metric definition for filterPattern. In any case, this is a good validation to have since the 'menu' placeholder value isn't valid for starting a LiveTail session anyways.
Updating telemetry to accommodate changes in aws/aws-toolkit-common#932 Update package version for telemetry. Add validation on the LogStreamFilter submenu's response for filter type. This is needed to allow the type returned from the LogStreamFilterSubmenu to be convertible to the type in the metric definition for filterPattern. In any case, this is a good validation to have since the 'menu' placeholder value isn't valid for starting a LiveTail session anyways.
2 participants
Problem
Addresses feedback on #916.
Solution
hasTextFilterinstead of defining a newhasLogEventFilterPatternpropertyfilterPatterntype, as an enum that supports logStream filter type stringscloudwatchlogs_startLiveTailandcloudwatchlogs_stopLiveTailLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.