Skip to content

telemetry(AmazonQ): Adding amazonq_feedback event for feedback #969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 5, 2025
Merged

telemetry(AmazonQ): Adding amazonq_feedback event for feedback #969

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb7ecf9
Adding a generic event for Amazon Q feedback
laileni-aws Jan 30, 2025
9d4ff12
Minor lint fix
laileni-aws Jan 30, 2025
e1af12b
Addressing comments
laileni-aws Jan 31, 2025
59b7eec
Addressing comments
laileni-aws Feb 3, 2025
277ae32
Adding allowed values to the interactionType
laileni-aws Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 32 additions & 28 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1251,6 +1251,8 @@
"description": "The id of the feature the user is interacting in. See also: `component`, `featureId`, `module`, `resourceType`.",
"allowedValues": [
"amazonQ",
"amazonQTest",
"amazonQReview",
"awsExplorer",
"awsToolkit",
"codewhisperer",
Expand Down Expand Up @@ -1870,6 +1872,15 @@
"type": "string",
"description": "A generic version metadata"
},
{
"name": "vote",
"type": "string",
"description": "User can click on thumbs up or thumbs down for feedback.",
"allowedValues": [
"downvote",
"upvote"
]
},
{
"name": "workflowToken",
"type": "string",
Expand Down Expand Up @@ -1977,34 +1988,6 @@
}
]
},
{
"name": "amazonq_approachThumbsDown",
Copy link
Contributor

@dhruvigajjar dhruvigajjar Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this metric is used by multiple IDEs. did you check if it's no longer in use? If not then it will break their code.

Copy link
Contributor Author

@laileni-aws laileni-aws Feb 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, confirmed with @jpinkney-aws , this is not being used by any team in both IDE's.

"description": "User clicked on the thumbs down button to say that they are unsatisfied",
"unit": "Count",
"metadata": [
{
"type": "amazonqConversationId"
},
{
"type": "credentialStartUrl",
"required": false
}
]
},
{
"name": "amazonq_approachThumbsUp",
"description": "User clicked on the thumbs up button, to mention that they are satisfied",
"unit": "Count",
"metadata": [
{
"type": "amazonqConversationId"
},
{
"type": "credentialStartUrl",
"required": false
}
]
},
{
"name": "amazonq_bundleExtensionIgnored",
"description": "File extension was ignored 'count' many times during bundling process",
Expand Down Expand Up @@ -2156,6 +2139,27 @@
}
]
},
{
"name": "amazonq_feedback",
"description": "When a user gives feedback using vote or comment or rating in the conversation",
"metadata": [
{
"type": "amazonqConversationId",
"required": false
},
{
"type": "credentialStartUrl",
"required": false
},
{
"type": "featureId"
},
{
"type": "vote",
"required": false
}
]
},
{
"name": "amazonq_interactWithMessage",
"description": "When a user interacts with a message in the conversation",
Expand Down