Skip to content

vsc: add source to common fields #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025
Merged

vsc: add source to common fields #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1782,7 +1782,7 @@
{
"name": "source",
"type": "string",
"description": "The source of the operation"
"description": "The source of the operation. This answers 'who' caused/triggered the operation. Example: did an Auth signout happen because of some expiration or since the user explicitly clicked the signout button."
},
{
"name": "sourceFacetType",
Expand Down
1 change: 1 addition & 0 deletions telemetry/vscode/src/generate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ const commonMetadata = [
'requestId',
'requestServiceType',
'result',
'source',
] as const

/**
Expand Down
2 changes: 2 additions & 0 deletions telemetry/vscode/test/resources/generatorOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ export interface MetricBase {
readonly requestServiceType?: string
/** The result of the operation */
readonly result?: Result
/** The source of the operation. This answers 'who' caused/triggered the operation. Example: did an Auth signout happen because of some expiration or since the user explicitly clicked the signout button. */
readonly source?: string
/** A flag indicating that the metric was not caused by the user. */
readonly passive?: boolean
/** @deprecated Arbitrary "value" of the metric. */
Expand Down
2 changes: 2 additions & 0 deletions telemetry/vscode/test/resources/generatorOverrideOutput.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ export interface MetricBase {
readonly requestServiceType?: string
/** The result of the operation */
readonly result?: Result
/** The source of the operation. This answers 'who' caused/triggered the operation. Example: did an Auth signout happen because of some expiration or since the user explicitly clicked the signout button. */
readonly source?: string
/** A flag indicating that the metric was not caused by the user. */
readonly passive?: boolean
/** @deprecated Arbitrary "value" of the metric. */
Expand Down