Skip to content

Commit a392dfa

Browse files
authored
Fix reporting sam version metric on sam deploy (#2478)
1 parent e2e57d6 commit a392dfa

File tree

1 file changed

+22
-5
lines changed

1 file changed

+22
-5
lines changed

jetbrains-core/src/software/aws/toolkits/jetbrains/services/lambda/actions/DeployServerlessApplicationAction.kt

Lines changed: 22 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import software.aws.toolkits.jetbrains.services.cloudformation.stack.StackWindow
3636
import software.aws.toolkits.jetbrains.services.cloudformation.validateSamTemplateHasResources
3737
import software.aws.toolkits.jetbrains.services.lambda.LambdaHandlerResolver
3838
import software.aws.toolkits.jetbrains.services.lambda.deploy.DeployServerlessApplicationDialog
39+
import software.aws.toolkits.jetbrains.services.lambda.sam.SamCommon
3940
import software.aws.toolkits.jetbrains.services.lambda.sam.SamExecutable
4041
import software.aws.toolkits.jetbrains.services.lambda.upload.UploadFunctionContinueDialog
4142
import software.aws.toolkits.jetbrains.services.lambda.upload.steps.DeployLambda
@@ -110,7 +111,11 @@ class DeployServerlessApplicationAction : AnAction(
110111
val stackDialog = DeployServerlessApplicationDialog(project, templateFile)
111112
stackDialog.show()
112113
if (!stackDialog.isOK) {
113-
SamTelemetry.deploy(project, Result.Cancelled)
114+
SamTelemetry.deploy(
115+
project = project,
116+
version = SamCommon.getVersionString(),
117+
result = Result.Cancelled
118+
)
114119
return@runInEdt
115120
}
116121

@@ -156,7 +161,7 @@ class DeployServerlessApplicationAction : AnAction(
156161
if (!response) {
157162
// TODO this telemetry needs to be improved. The user can finish the deployment later so we do not know if
158163
// it is actually cancelled or not
159-
SamTelemetry.deploy(project = project, result = Result.Cancelled)
164+
SamTelemetry.deploy(project = project, version = SamCommon.getVersionString(), result = Result.Cancelled)
160165
return@runBlocking
161166
}
162167
}
@@ -178,12 +183,20 @@ class DeployServerlessApplicationAction : AnAction(
178183
message("cloudformation.execute_change_set.success", stackName),
179184
project
180185
)
181-
SamTelemetry.deploy(project, Result.Succeeded)
186+
SamTelemetry.deploy(
187+
project = project,
188+
version = SamCommon.getVersionString(),
189+
result = Result.Succeeded
190+
)
182191
// Since we could update anything, do a full refresh of the resource cache and explorer
183192
project.refreshAwsTree()
184193
} catch (e: Exception) {
185194
e.notifyError(message("cloudformation.execute_change_set.failed", stackName), project)
186-
SamTelemetry.deploy(project, Result.Failed)
195+
SamTelemetry.deploy(
196+
project = project,
197+
version = SamCommon.getVersionString(),
198+
result = Result.Failed
199+
)
187200
}
188201
}
189202

@@ -197,7 +210,11 @@ class DeployServerlessApplicationAction : AnAction(
197210

198211
workflow.onError = {
199212
it.notifyError(project = project, title = message("lambda.service_name"))
200-
SamTelemetry.deploy(project = project, result = Result.Failed)
213+
SamTelemetry.deploy(
214+
project = project,
215+
version = SamCommon.getVersionString(),
216+
result = Result.Failed
217+
)
201218
}
202219

203220
workflow.startExecution()

0 commit comments

Comments
 (0)