Skip to content

Commit e2e57d6

Browse files
authored
Add deprecation warning for 2020.1 (#2476)
1 parent 7001d40 commit e2e57d6

File tree

2 files changed

+7
-12
lines changed

2 files changed

+7
-12
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
{
2+
"type" : "deprecation",
3+
"description" : "2020.1 support will be removed in the next release"
4+
}

jetbrains-core/src/software/aws/toolkits/jetbrains/core/notification/JetBrainsMinimumVersionChange.kt

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ import com.intellij.openapi.application.ApplicationNamesInfo
99
import software.aws.toolkits.resources.message
1010

1111
class JetBrainsMinimumVersionChange : NoticeType {
12-
override val id: String = "JetBrainsMinimumVersion_201"
12+
override val id: String = "JetBrainsMinimumVersion_202"
1313
private val noticeContents = NoticeContents(
1414
message("notice.title.jetbrains.minimum.version"),
1515
message(
1616
"notice.message.jetbrains.minimum.version",
1717
ApplicationInfo.getInstance().fullVersion,
1818
ApplicationNamesInfo.getInstance().fullProductName,
19-
"2020.1"
19+
"2020.2"
2020
)
2121
)
2222

@@ -29,16 +29,7 @@ class JetBrainsMinimumVersionChange : NoticeType {
2929
return false
3030
}
3131

32-
override fun isNotificationRequired(): Boolean {
33-
val appInfo = ApplicationInfo.getInstance()
34-
val majorVersion = appInfo.majorVersion.toIntOrNull()
35-
36-
majorVersion?.let {
37-
return majorVersion < 2020
38-
}
39-
40-
return true
41-
}
32+
override fun isNotificationRequired(): Boolean = ApplicationInfo.getInstance().build.baselineVersion < 202
4233

4334
override fun getNoticeContents(): NoticeContents = noticeContents
4435
override fun getNoticeType(): NotificationType = NotificationType.WARNING

0 commit comments

Comments
 (0)