Skip to content

Conversation

@dogusata
Copy link
Contributor

@dogusata dogusata commented Apr 11, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Fixed quick action commands inconsistency between Q tabs and prompt input not getting autofocus when code is sent.
Added no tabs description with open new tab button when no tab is open

Problem

  • Quick action commands are inconsistent between Q tabs (/dev, /transform and q chat)
  • Prompt input doesn't get focus when user sends code to Q chat
  • No indication when all tabs closed.

Solution

  • All quick action commands are now visible in all Q tab types. But depending on the tab type, some of them are disabled with description messages.
  • Prompt input now gets auto focus after code is sent to Q chat. It is solved with mynah-ui update which is available from version 4.5.4
  • Added indication and open new tab button when all tabs are closed with a mynah-ui update which is available from 4.5.3

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

fixed quick action commands inconsistency between Q tabs
added no tabs description with open new tab button when no tab is open
@dogusata dogusata requested review from a team as code owners April 11, 2024 12:49
fixed quick action commands inconsistency between Q tabs
added no tabs description with open new tab button when no tab is open
@dogusata dogusata requested a review from a team as a code owner April 12, 2024 18:22
@dogusata dogusata changed the title fixed autofocus to prompt input after code sent to Q (MynahUI: 4.5.4) fixed autofocus to prompt input after code sent to Q (MynahUI: 4.5.5) Apr 12, 2024
@dogusata dogusata changed the title fixed autofocus to prompt input after code sent to Q (MynahUI: 4.5.5) fix(amazonq): Quick Action commands are inconsistent between Q tabs and prompt input not getting focus after code sent to Q Apr 12, 2024
@mk-fan
Copy link
Contributor

mk-fan commented Apr 12, 2024

I opened a transformation tab, and tried to access the quick actions in a separate tab, but saw them all getting disabled.

Screenshot 2024-04-12 at 11 36 45 AM

@dogusata
Copy link
Contributor Author

dogusata commented Apr 12, 2024

Thanks for informing Mike, i'll take a look, did you switch to the tab while the quick actions overlay open?

fixed quick action commands inconsistency between Q tabs
added no tabs description with open new tab button when no tab is open
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rli
Copy link
Contributor

rli commented Apr 23, 2024

#4330

@rli rli closed this Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants