fix 404 not found page with PKCE flow by closing previous netty channel #4621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Jun 27, 2024
| return request.uri().trim('/').startsWith("oauth/callback") | ||
| } | ||
| // only handle the /oauth/callback endpoint | ||
| override fun isSupported(request: FullHttpRequest) = request.uri().trim('/').startsWith("oauth/callback") |
Contributor
There was a problem hiding this comment.
probably also want to restrict to HTTP GET
Will-ShaoHua
commented
Jul 29, 2024
| } | ||
| // if (!oauthService().hasPendingRequest()) { | ||
| // return false | ||
| // } |
Contributor
Author
There was a problem hiding this comment.
confirmed that tcp connection will indeed be closed if cancel button is clicked (Auth completableFuture will be closed)
Screen.Recording.2024-07-29.at.3.17.14.AM.mov
Will-ShaoHua
changed the title
manodnyab
approved these changes
Aug 21, 2024
Contributor
|
Cleaner solution in #4924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-07-26.at.6.49.46.PM.mov
Screen.Recording.2024-07-26.at.6.50.10.PM.mov
Screen.Recording.2024-07-26.at.6.50.40.PM.mov
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.