Skip to content

Conversation

leigaol
Copy link
Contributor

@leigaol leigaol commented Sep 16, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Since launch, the has project context flag of user Interaction event in JetBrains only depends on the user settings enabled or not. However, this boolean field should be getIsProjectContextEnabled() && data.useRelevantDocuments && data.relevantTextDocuments.isNotEmpty()

This PR is to correct this boolean field. It has no customer impact.
Test is performed manually from build artifacts.

This PR depends on #4886

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@leigaol leigaol requested a review from a team as a code owner September 16, 2024 20:36
@leigaol leigaol requested a review from zixlin7 September 16, 2024 20:36
@leigaol leigaol marked this pull request as draft September 16, 2024 21:47
@leigaol leigaol marked this pull request as ready for review September 17, 2024 02:09
@leigaol leigaol requested a review from a team as a code owner September 17, 2024 02:09
@leigaol leigaol merged commit 26e28f6 into aws:main Sep 18, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants