Skip to content

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Sep 16, 2024

Description

Per product team's request, unblock requests of the following language to the service which will be ready soon. (thus not calling it out as a "feat")

image

functional test

jb-systemverilog.mov
jb-vue.mov
jb-swift.mov
jb-r.mov
jb-powershell.mov
jb-dart.mov
jb-lua.mov

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners September 16, 2024 22:54
@Will-ShaoHua Will-ShaoHua marked this pull request as draft September 16, 2024 22:55
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review September 19, 2024 20:48
@Will-ShaoHua Will-ShaoHua changed the title lang expansion inline completion lang expansion preparation Sep 21, 2024
@Will-ShaoHua Will-ShaoHua requested review from leigaol and rli September 23, 2024 20:06
Comment on lines +207 to +211
@Rule
@JvmField
val applicationRule = ApplicationRule()

val suts = listOf(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Will-ShaoHua Will-ShaoHua changed the title inline completion lang expansion preparation inline completion lang expansion Oct 7, 2024
@Will-ShaoHua Will-ShaoHua changed the title inline completion lang expansion config(amazonq) Inline completion language expansion Oct 8, 2024
@Will-ShaoHua Will-ShaoHua changed the title config(amazonq) Inline completion language expansion config(amazonq) unblock several languages generateCompletion requests to the service Oct 8, 2024
@Will-ShaoHua Will-ShaoHua merged commit 6afc927 into aws:main Oct 9, 2024
9 of 12 checks passed
@Will-ShaoHua Will-ShaoHua deleted the cwspr-inline-lang branch October 9, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants