Skip to content

Conversation

@dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Sep 17, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Prompt the user with a form asking them if they want us to skip integ tests or skip all tests when doing our server-side build. Pass the flag via the manifest.json.

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested review from a team as code owners September 17, 2024 01:42
@dhasani23
Copy link
Contributor Author

Note: backend work for this feature is not done yet, so not planning on merging this PR quite yet

@dhasani23
Copy link
Contributor Author

dhasani23 commented Sep 17, 2024

image

@dhasani23 dhasani23 force-pushed the customBuildCommand branch 4 times, most recently from 7742c09 to f9f8fe5 Compare September 19, 2024 22:02
Copy link

@JuliaABurch JuliaABurch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending final string review


private val transformationStoppedByUsr = AtomicBoolean(false)
private var codeTransformationSession: CodeModernizerSession? = null
var codeTransformationSession: CodeModernizerSession? = null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see if you can make this private again

@rli rli merged commit fa3dcf2 into aws:main Sep 25, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants