Add 243 build profile #4899
Merged
Add 243 build profile #4899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVM8 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
commented
Oct 10, 2024
There was a problem hiding this comment.
there are lots of EDT warnings in 243 but i don't think its worth the time to investigate at right now
manodnyab
reviewed
Oct 11, 2024
| intellijGradle = "2.1.0" | ||
| intellijRemoteRobot = "0.11.22" | ||
| jackson = "2.16.1" | ||
| jackson = "2.17.2" |
There was a problem hiding this comment.
We had reverted this to 2.16.1 in a previous version: https://github.com/aws/aws-toolkit-jetbrains/pull/4732/files because it broke chat, just confirming if we know if that's been fixed?
There was a problem hiding this comment.
yes we now remove the conflicting jackson jars from our distribution
manodnyab
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.