Skip to content

Conversation

@rli
Copy link
Contributor

@rli rli commented Sep 24, 2024

supportsConnectionType is called very frequently

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rli rli requested a review from a team as a code owner September 24, 2024 19:34
@github-actions
Copy link

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Copy link
Contributor

@samgst-amazon samgst-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was seeing this a lot the other day. Is there a reason why CodeCatalystConnection gets checked so much?

@rli
Copy link
Contributor Author

rli commented Sep 24, 2024

well it looks like it gets called every single time BearerTokenProviderListener#onChange is called to drive some explorer refresh logic, but i'm not sure it needs to do that....

@rli rli merged commit 03b8f32 into main Sep 24, 2024
13 of 16 checks passed
@rli rli deleted the rli/coca-noise branch September 24, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants