Skip to content

Fix compilation issue with Function<...> in JBCef callback handler #4912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Fix compilation issue with Function<...> in JBCef callback handler #4912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...software/aws/toolkits/jetbrains/services/amazonq/gettingstarted/QGettingStartedContent.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@
AmazonQToolWindow.getStarted(project)
}
}
null

JBCefJSQuery.Response(null)

Check warning on line 66 in plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/gettingstarted/QGettingStartedContent.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/gettingstarted/QGettingStartedContent.kt#L66 

Added line #L66 was not covered by tests
}
receiveMessageQuery.addHandler(handler)
}
Expand Down
3 changes: 0 additions & 3 deletions ...tbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/Browser.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ import com.intellij.openapi.util.Disposer
import com.intellij.ui.jcef.JBCefJSQuery
import org.cef.CefApp
import software.aws.toolkits.jetbrains.services.amazonq.util.createBrowser
import java.util.function.Function

typealias MessageReceiver = Function<String, JBCefJSQuery.Response>

/*
Displays the web view for the Amazon Q tool window
Expand Down
2 changes: 1 addition & 1 deletion ...ommunity/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
private fun addMessageHook(browser: Browser) = callbackFlow {
val handler = Function<String, Response> {
trySend(it)
null
Response(null)

Check warning on line 80 in plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt

View check run for this annotation

Codecov / codecov/patch

plugins/amazonq/chat/jetbrains-community/src/software/aws/toolkits/jetbrains/services/amazonq/webview/BrowserConnector.kt#L80 

Added line #L80 was not covered by tests
}

browser.receiveMessageQuery.addHandler(handler)
Expand Down
2 changes: 1 addition & 1 deletion ...core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/webview/LoginBrowser.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@

handleBrowserMessage(obj)

null
JBCefJSQuery.Response(null)

Check warning on line 74 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/webview/LoginBrowser.kt

View check run for this annotation

Codecov / codecov/patch

plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/webview/LoginBrowser.kt#L74 

Added line #L74 was not covered by tests
}
protected var currentAuthorization: PendingAuthorization? = null

Expand Down
Loading