Skip to content

revert(amazonq): revert allow users to skip tests #4920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024
Merged

revert(amazonq): revert allow users to skip tests #4920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aee98eb
revert(amazonq): revert allow users to skip tests
Sep 26, 2024
380ec7d
fix detekt errors
Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .changes/next-release/feature-e16b5994-34c8-465b-b0a9-386590a7d9ea.json
View file
Open in desktop

This file was deleted.

8 changes: 6 additions & 2 deletions .../aws/toolkits/jetbrains/services/codemodernizer/controller/CodeTransformChatController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildTr
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserCancelledChatContent
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserHilSelection
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserInputChatContent
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserInputSkipTestsFlagChatContent
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserInputSkipTestsFlagChatIntroContent
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserSelectionSummaryChatContent
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserSkipTestsFlagSelectionChatContent
import software.aws.toolkits.jetbrains.services.codemodernizer.constants.buildUserStopTransformChatContent
Expand Down Expand Up @@ -229,10 +227,16 @@ class CodeTransformChatController(
// Publish metric to capture user selection before local build starts
telemetry.submitSelection("Confirm", selection)

// TO-DO: delete this line when backend issue is fixed
codeModernizerManager.codeTransformationSession?.let { codeModernizerManager.runLocalMavenBuild(context.project, it) }

// TO-DO: uncomment these lines when backend issue is fixed
/*
codeTransformChatHelper.run {
addNewMessage(buildUserInputSkipTestsFlagChatIntroContent())
addNewMessage(buildUserInputSkipTestsFlagChatContent())
}
*/
}

override suspend fun processCodeTransformConfirmSkipTests(message: IncomingCodeTransformMessage.CodeTransformConfirmSkipTests) {
Expand Down
Loading