Skip to content

feat(amazonq): loosen inline suggestion restriction for json/yaml files #4928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 9, 2024
Merged

feat(amazonq): loosen inline suggestion restriction for json/yaml files #4928

merged 15 commits into from
Oct 9, 2024

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Oct 1, 2024 •
edited
Loading

VSC PR aws/aws-toolkit-vscode#5733

YAML files

  • Provide completions for all YAML files.

  • Remove any current CloudFormation-only restrictions for YAML

JSON files

  • Provide completions for a JSON file if the filename matches one of the below names or the file content matches the CloudFormation regexp.
    app.json
    appsettings.json
    bower.json
    composer.json
    db.json
    manifest.json
    package.json
    schema.json
    settings.json
    tsconfig.json
    vcpkg.json

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner October 1, 2024 17:57
@Will-ShaoHua Will-ShaoHua marked this pull request as draft October 1, 2024 18:00
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review October 1, 2024 18:20
@Will-ShaoHua Will-ShaoHua marked this pull request as draft October 1, 2024 21:06
@Will-ShaoHua Will-ShaoHua changed the title loose inline suggestion support restriction for json/yaml files loose inline suggestion restriction for json/yaml files Oct 1, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review October 6, 2024 05:50
@Will-ShaoHua Will-ShaoHua mentioned this pull request Oct 6, 2024
Merged
@Will-ShaoHua Will-ShaoHua changed the title loose inline suggestion restriction for json/yaml files feat(Q Developer) loose inline suggestion restriction for json/yaml files Oct 6, 2024
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner October 7, 2024 19:37
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Oct 7, 2024 •
edited
Loading

updated case ignore @andrewyuq 736da64

@Will-ShaoHua Will-ShaoHua requested a review from andrewyuq October 7, 2024 19:55
@Will-ShaoHua Will-ShaoHua changed the title feat(Q Developer) loose inline suggestion restriction for json/yaml files feat(amazonq) loose inline suggestion restriction for json/yaml files Oct 8, 2024
@Will-ShaoHua Will-ShaoHua changed the title feat(amazonq) loose inline suggestion restriction for json/yaml files feat(amazonq): loose inline suggestion restriction for json/yaml files Oct 8, 2024
rli
rli approved these changes Oct 8, 2024
View reviewed changes
...src/software/aws/toolkits/jetbrains/services/codewhisperer/editor/CodeWhispererEditorUtil.kt Outdated
(!CodeWhispererConstants.AWSTemplateCaseInsensitiveKeyWordsRegex.containsMatchIn(leftContext.lowercase(Locale.getDefault())))
)
fun isSupportedJsonFormat(fileName: String, leftContext: String, language: CodeWhispererProgrammingLanguage): Boolean {
assert(language is CodeWhispererJson)
Copy link
Contributor

@rli rli Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably shouldn't throw?

Copy link
Contributor Author

@Will-ShaoHua Will-ShaoHua Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack

@Will-ShaoHua Will-ShaoHua changed the title feat(amazonq): loose inline suggestion restriction for json/yaml files feat(amazonq): loosen inline suggestion restriction for json/yaml files Oct 8, 2024
@Will-ShaoHua Will-ShaoHua merged commit 90fda64 into aws:main Oct 9, 2024
9 of 12 checks passed
@Will-ShaoHua Will-ShaoHua deleted the yaml branch October 9, 2024 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

@manodnyab manodnyab manodnyab approved these changes

@andrewyuq andrewyuq andrewyuq approved these changes

+1 more reviewer

@zixlin7 zixlin7 zixlin7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Will-ShaoHua @rli @zixlin7 @manodnyab @andrewyuq