Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Oct 6, 2024

Problem

JB PR aws/aws-toolkit-jetbrains#4928

Per product team's request, change condition when we support generateCompletion for YAML/JSON

YAML files

  • Provide completions for all YAML files.

  • Remove any current CloudFormation-only restrictions for YAML

JSON files

  • Provide completions for a JSON file if the filename matches one of the below names or the file content matches the CloudFormation regexp.
    app.json
    appsettings.json
    bower.json
    composer.json
    db.json
    manifest.json
    package.json
    schema.json
    settings.json
    tsconfig.json
    vcpkg.json

Solution


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner October 6, 2024 08:36
@github-actions
Copy link

github-actions bot commented Oct 6, 2024

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@Will-ShaoHua Will-ShaoHua changed the title loose Q inline completion support restriction for yaml/json files feat(Q Developer) loose inline suggestion restriction for json/yaml files Oct 6, 2024
@github-actions
Copy link

github-actions bot commented Oct 6, 2024

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

@Will-ShaoHua Will-ShaoHua changed the title feat(Q Developer) loose inline suggestion restriction for json/yaml files feat(amzonq) loose inline suggestion restriction for json/yaml files Oct 6, 2024
@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner October 7, 2024 19:31
@Will-ShaoHua Will-ShaoHua changed the title feat(amzonq) loose inline suggestion restriction for json/yaml files feat(amzonq) loosen inline suggestion restriction for json/yaml files Oct 8, 2024
@Will-ShaoHua Will-ShaoHua changed the title feat(amzonq) loosen inline suggestion restriction for json/yaml files feat(amzonq): loosen inline suggestion restriction for json/yaml files Oct 9, 2024
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Oct 9, 2024

think failing test isn't related to this PR

2631 passing (1m)
12 pending
1 failing

  1. startSecurityScanPerformanceTest
    Should calculate cpu and memory usage for file scans performance tests
    "after all" hook for "Should calculate cpu and memory usage for file scans - test run 10":

    AssertionError [ERR_ASSERTION]: Expected total user CPU usage for Should calculate cpu and memory usage for file scans to be less than 50. Actual user CPU usage was 50.67705300541362

    • expected - actual

    -false
    +true

    at assertPerformanceMetrics (/codebuild/output/src502230826/src/github.com/aws/aws-toolkit-vscode/packages/core/src/shared/performance/performance.ts:182:11)
    at Context. (/codebuild/output/src502230826/src/github.com/aws/aws-toolkit-vscode/packages/core/src/shared/performance/performance.ts:160:13)
    at processImmediate (node:internal/timers:476:21)
    at process.topLevelDomainCallback (node:domain:161:15)
    at process.callbackTrampoline (node:internal/async_hooks:128:24)

@justinmk3 justinmk3 merged commit e7962f3 into aws:master Oct 9, 2024
9 of 12 checks passed
@Will-ShaoHua Will-ShaoHua deleted the yaml branch October 10, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants