fix(dev): Include "no change required exception" for EmptyPatch #4938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tverney
force-pushed
the
fix/empty-patch
branch
from
89b0720 to
335f288
Compare
...rc/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt
Outdated
Show resolved
Hide resolved
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt
Outdated
Show resolved
Hide resolved
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt
Show resolved
Hide resolved
manodnyab
reviewed
Oct 7, 2024
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt
Outdated
Show resolved
Hide resolved
.changes/next-release/bugfix-35b9862b-8817-42e0-a6bd-dca53c3d50a3.json
Outdated
Show resolved
Hide resolved
4 tasks
…kits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt Co-authored-by: manodnyab <[email protected]>
manodnyab
reviewed
Oct 9, 2024
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt
Outdated
Show resolved
Hide resolved
.changes/next-release/bugfix-35b9862b-8817-42e0-a6bd-dca53c3d50a3.json
Outdated
Show resolved
Hide resolved
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt
Outdated
Show resolved
Hide resolved
…kits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt Co-authored-by: manodnyab <[email protected]>
manodnyab
approved these changes
Oct 10, 2024
rli
reviewed
Oct 10, 2024
plugins/core/resources/resources/software/aws/toolkits/resources/MessagesBundle.properties
Outdated
Show resolved
Hide resolved
rli
pushed a commit
that referenced
this pull request
Oct 10, 2024
…servability (#4953) **Problem:** Feature dev instrumentation 1) records all failures as `FeatureDevException`, losing information about the specific exception type, and 2) lacks annotation of `reasonDesc` and the operation related to the error. (By operation, although we do capture `amazonq_codeGenerationInvoke`, we're missing the subprocess name such as `StartCodeGeneration`.) As a result, we do not have insight into feature dev failures in JetBrains. **Solution:** 1) Update exception modeling pattern for feature dev functionality to derive subclasses of `FeatureDevException`, providing a meaningful class name when inspected as error `reason`. 2) On `FeatureDevException`, accept an `operation` and `desc` to provide further annotation (merged when logged as `reasonDesc`). This change will have conflicts with #4938 and #4949. I'll rebase on top of those and reconcile any drift in a subsequent revision.
…es/MessagesBundle.properties Co-authored-by: Richard Li <[email protected]>
rli
reviewed
Oct 10, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/FeatureDevExceptions.kt
Outdated
Show resolved
Hide resolved
…kits/jetbrains/services/amazonqFeatureDev/FeatureDevExceptions.kt Co-authored-by: Richard Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem
Q dev won't be able to generate code for unrelated prompts. (e.g. explain the code)
It would be a bad CX if Q fail to generate code without guiding users the proper use cases.
Solution
Handle no code change required explicitly.
Allow users to provide more details
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.