feat(dev): Stop code generation action #4948

tverney · 2024-10-08T14:48:12Z

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description

Currently /dev don't support stop code generation. This PR introduces this functionality (watch the video below).

Mynah UI provides onStopChatResponse API which we can hook in the cancellation token provided on VS Code, sharing across an active session, aborting current progress.

Screen.Recording.2024-10-16.at.10.11.20.AM.mov

VS Code side: aws/aws-toolkit-vscode#5675

Checklist

My code follows the code style of this project
I have added tests to cover my changes
A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

This reverts commit aa1a1c4.

This reverts commit 03f33d2.

...ty/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererConstants.kt

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt

...s/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt

...rc/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt

tverney · 2024-10-16T19:27:35Z

!!Important - FYI toolkit team: this is only to be merged in next week's release. CC: @neilk-aws

...s/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt

+            tabId = tabId,
+            followUp = listOf(
+                FollowUp(
+                    pillText = message("amazonqFeatureDev.follow_up.new_task"),


...s/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt

+
+private fun FeatureDevController.openChatNotificationAction() =
+    NotificationAction.createSimple(
+        message("amazonqFeatureDev.code_generation.notification_open_link"),


rli

very difficult to review with all the whitespace changes

rli · 2024-10-23T01:45:52Z

plugins/core/sdk-codegen/codegen-resources/codewhispererruntime/service-2.json

please minimize the diff. try the contents of *.normal.json instead

plugins/core/jetbrains-community/resources/telemetryOverride.json

.../src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/SessionStateTypes.kt

...-community/src/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/Session.kt

detekt-rules/tst/software/aws/toolkits/gradle/detekt/rules/LazyLogRuleTest.kt

...s/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt

...rc/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt

...rc/software/aws/toolkits/jetbrains/services/amazonqFeatureDev/session/CodeGenerationState.kt

…kits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt Co-authored-by: Richard Li <[email protected]>

...s/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt

…kits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt Co-authored-by: Richard Li <[email protected]>

...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt

...s/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt

                tabId = tabId,
                messageType = FeatureDevMessageType.Answer,
-                message = message("amazonqFeatureDev.code_generation.no_file_changes")
+                message = message("amazonqFeatureDev.code_generation.no_file_changes"),


…etry.click

telemetry(amazonq): replace stopCodeGeneration telemetry with UiTelemetry.click

...mmunity/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/BuildStepStatus.kt

plugins/amazonq/mynah-ui/src/mynah-ui/ui/connector.ts

tverney and others added 7 commits October 15, 2024 15:59

fix(amazonqFeatureDev): include stop generation

ba719b6

fix(amazonqFeatureDev): add token for stop gen

153ddb8

Revert "fix(amazonqFeatureDev): include stop generation"

98aac91

This reverts commit aa1a1c4.

Revert "Revert "fix(amazonqFeatureDev): include stop generation""

dabd53c

This reverts commit 03f33d2.

fix(amazonqFeatureDev): include cancellation token

67c231d

fix(amazonqFeatureDev): include defaults for empty string

9150d7e

telemetry(amazonq): add metrics for stop code generation

7f84621

tverney force-pushed the feature/stop-generation branch from 681f5c0 to 7f84621 Compare October 15, 2024 20:05

tverney added 3 commits October 16, 2024 11:24

fix(dev): messaging

08367d4

fix(dev): improve messaging

535cfc9

chore(dev): include changelog

5ee4abf

tverney marked this pull request as ready for review October 16, 2024 15:35

tverney requested review from a team as code owners October 16, 2024 15:35

tverney added 3 commits October 16, 2024 12:31

fix(dev): apply lint for build

d43eb50

Merge branch 'main' into feature/stop-generation

c080c6c

fix(dev): update ident and unecessary safe type check

1877f34

neilk-aws suggested changes Oct 16, 2024

View reviewed changes

...ty/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererConstants.kt Outdated Show resolved Hide resolved

Update CodeWhispererConstants.kt

446d5b2

tverney requested a review from neilk-aws October 16, 2024 16:53

neilk-aws approved these changes Oct 16, 2024

View reviewed changes

tverney added 2 commits October 16, 2024 13:31

Merge branch 'main' into feature/stop-generation

ccd5ebc

fix(dev): update tests

eb8cc1d

github-advanced-security bot found potential problems Oct 16, 2024

View reviewed changes

tverney added 2 commits October 16, 2024 14:03

fix(dev): update tests

aeeee4a

fix(dev): use string instead of UUID in startAssist to help on testing

6f99d90

github-advanced-security bot found potential problems Oct 22, 2024

View reviewed changes

fix(dev): update formatting

68a37f2

neilk-aws approved these changes Oct 22, 2024

View reviewed changes

Merge branch 'main' into feature/stop-generation

71b03d7

rli reviewed Oct 23, 2024

View reviewed changes

tverney and others added 2 commits October 22, 2024 22:31

Delete package-lock.json

1e96798

Update plugins/amazonq/chat/jetbrains-community/src/software/aws/tool…

97c760b

…kits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt Co-authored-by: Richard Li <[email protected]>

github-advanced-security bot found potential problems Oct 23, 2024

View reviewed changes

...s/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt Fixed Show fixed Hide fixed

tverney and others added 5 commits October 22, 2024 23:09

fix(dev): remove disposeToken as plugin

565244a

fix(dev): revert lazy log file per request

1d04af9

fix(dev): remove redundant reassign

a7477aa

Update plugins/amazonq/chat/jetbrains-community/src/software/aws/tool…

be9f818

…kits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevControllerExtensions.kt Co-authored-by: Richard Li <[email protected]>

fix(dev): change number to int for iterations number

41f0403

github-advanced-security bot found potential problems Oct 23, 2024

View reviewed changes

tverney added 3 commits October 23, 2024 07:32

fix(dev): use val instead

914b140

fix(dev): replace gradle dependency for our own cancellation token

c17a0f1

fix(dev): removed gradle and added our own cancellation token

d84a9e2

github-advanced-security bot found potential problems Oct 23, 2024

View reviewed changes

tverney requested a review from rli October 23, 2024 18:34

tverney and others added 3 commits October 23, 2024 14:51

Merge branch 'main' into feature/stop-generation

ae7f9c6

telemetry(amazonq): replace stopCodeGeneration telemetry with UiTelem…

d11f7e2

…etry.click

Merge pull request #2 from kelvin-klchu/stop-code-gen-telemetry

2eea363

telemetry(amazonq): replace stopCodeGeneration telemetry with UiTelemetry.click

rli reviewed Oct 23, 2024

View reviewed changes

...mmunity/src/software/aws/toolkits/jetbrains/services/codemodernizer/model/BuildStepStatus.kt Outdated Show resolved Hide resolved

fix(dev): remove todo section

2374e67

tverney requested a review from rli October 23, 2024 21:56

rli reviewed Oct 23, 2024

View reviewed changes

plugins/amazonq/mynah-ui/src/mynah-ui/ui/connector.ts Show resolved Hide resolved

fix(dev): add it back cwc on stop chat response

abf8f43

rli approved these changes Oct 23, 2024

View reviewed changes

fix build error

538eb00

rli merged commit 8dc4b81 into aws:main Oct 23, 2024
11 of 13 checks passed

feat(dev): Stop code generation action #4948

feat(dev): Stop code generation action #4948

Uh oh!

Conversation

tverney commented Oct 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Types of changes

Description

Checklist

License

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tverney commented Oct 16, 2024

Uh oh!

Check warning

Check warning

rli left a comment

Choose a reason for hiding this comment

Uh oh!

rli Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check warning

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tverney commented Oct 8, 2024 •

edited

Loading