Skip to content

Fix Jackson classloader issue while reading tokens from disk #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Fix Jackson classloader issue while reading tokens from disk #4994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changes/next-release/bugfix-7ce2cd74-c7b3-4856-9f9d-809240699858.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Fix issue where the plugin can't read SSO tokens from disk / always returns 'Unable to load client registration'"
}
4 changes: 0 additions & 4 deletions buildSrc/src/main/kotlin/toolkit-intellij-subplugin.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ configurations {
// IDE provides Kotlin
exclude(group = "org.jetbrains.kotlin")
exclude(group = "org.jetbrains.kotlinx")

exclude(group = "com.fasterxml.jackson.core")
exclude(group = "com.fasterxml.jackson.module", "jackson-module-kotlin")
exclude(group = "com.fasterxml.jackson.dataformat", "jackson-dataformat-yaml")
}

configureEach {
Expand Down
10 changes: 1 addition & 9 deletions buildSrc/src/main/kotlin/toolkit-publish-root-conventions.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ tasks.withType<PatchPluginXmlTask>().configureEach {
intellijPlatform {
instrumentCode = false

verifyPlugin {
pluginVerification {
ides {
// recommended() appears to resolve latest EAP for a product?
ide(provider { IntelliJPlatformType.IntellijIdeaCommunity }, toolkitIntelliJ.version())
Expand Down Expand Up @@ -65,14 +65,6 @@ dependencies {
}
}

configurations {
runtimeClasspath {
exclude(group = "com.fasterxml.jackson.core")
exclude(group = "com.fasterxml.jackson.module", "jackson-module-kotlin")
exclude(group = "com.fasterxml.jackson.dataformat", "jackson-dataformat-yaml")
}
}

tasks.runIde {
systemProperty("aws.toolkit.developerMode", true)
systemProperty("ide.plugins.snapshot.on.unload.fail", true)
Expand Down
Loading