Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Oct 22, 2024

Description

  • add test
  • without this change, encoderserver will still only be launched if the configuration is enabled

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested review from a team as code owners October 22, 2024 09:32

private fun assertEncoderServerStarted() = runTest {
mockConstruction(EncoderServer::class.java).use {
// val cs = TestScope(context = StandardTestDispatcher()) // not works and the test never finish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orz

@Will-ShaoHua Will-ShaoHua merged commit fa44967 into aws:main Oct 22, 2024
12 of 13 checks passed
@Will-ShaoHua Will-ShaoHua deleted the project-context-process branch October 22, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants