Skip to content

feat(amazonq): Increase polling rate for Q agent code summary #5007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 9 commits into from
Closed

feat(amazonq): Increase polling rate for Q agent code summary #5007

wants to merge 9 commits into from

Conversation

@juusticeTG
Copy link
Contributor

@juusticeTG juusticeTG commented Oct 23, 2024 •
edited
Loading

  • Decrease requestDelay to 5000ms from 10000ms to provide user with more frequent agent code change updates
  • Increased pollCount to 360 from 180 to accommodate for twice as frequent polling
  • Removed forced read-only view on before diff of agent code changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)

Description

Checklist

  • [ x ] My code follows the code style of this project
  • [ x ] I have added tests to cover my changes
  • [ x ] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@juusticeTG juusticeTG marked this pull request as ready for review October 23, 2024 21:49
@juusticeTG juusticeTG requested review from a team as code owners October 23, 2024 21:49
willyyhuang
willyyhuang suggested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@willyyhuang willyyhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update test:
toolkits.jetbrains.services.amazonqFeatureDev.session.CodeGenerationStateTest

rli
rli reviewed Oct 23, 2024
View reviewed changes
...oftware/aws/toolkits/jetbrains/services/amazonqFeatureDev/controller/FeatureDevController.kt
}

val request = SimpleDiffRequest(message.filePath, leftDiffContent, rightDiffContent, null, null)
request.putUserData(DiffUserDataKeys.FORCE_READ_ONLY, true)
Copy link
Contributor

@rli rli Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@rli rli mentioned this pull request Oct 28, 2024
Merged
2 tasks
@juusticeTG
Copy link
Contributor Author

juusticeTG commented Oct 28, 2024

Closing PR as it does not have all of the required changes

@juusticeTG juusticeTG closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

+2 more reviewers

@willyyhuang willyyhuang willyyhuang approved these changes

@neilk-aws neilk-aws neilk-aws approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@juusticeTG @rli @willyyhuang @neilk-aws @JuusticeT