fix perceivedLatency being calculated incorrectly #5013
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. perceivedLatency was previously calculated at the time of sending STE, but the timeOfLastCharTyped value is no longer accurate, so calculate the perceivedLatency value at suggestion showing time to get the most accurate timeOfLastCharTyped
Will-ShaoHua
approved these changes
Oct 25, 2024
justinmk3
pushed a commit
to aws/aws-toolkit-vscode
that referenced
this pull request
Oct 28, 2024
The perceivedLatency is currently calculated and sent when we send STE, by then lastUserModificationTime is no longer accurate. Instead calculate perceivedLatency when we show the suggestions and use the lastUserModificationTime at that time to be accurate. JB PR: aws/aws-toolkit-jetbrains#5013
rli
approved these changes
Oct 29, 2024
Comment on lines
+127
to
+129
| private fun connection(project: Project) = | ||
| ToolkitConnectionManager.getInstance(project).activeConnectionForFeature(QConnection.getInstance()) | ||
|
|
Contributor
There was a problem hiding this comment.
i think codewhispererconnection is safer, not sure if population has aged out of that one yet
Contributor
Author
There was a problem hiding this comment.
If we are deprecating 233 I think it's probably safe by now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSC PR: aws/aws-toolkit-vscode#5871
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.