Skip to content

Conversation

@laileni-aws
Copy link
Contributor

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Drop found in customer interaction with chat message because of replacing deprecated onCodeInsertToCursorPosition and onCopyCodeToClipboard functions with onCodeBlockActionClicked function. Commit Reference.

Reverted these deprecated onCodeInsertToCursorPosition and onCopyCodeToClipboard functions

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laileni-aws laileni-aws changed the title fix(amazonq): Drop found in customer interaction with chat message due to onCodeBlockActionClicked function fix(amazonq): Regression using onCodeBlockActionClicked function, replaced with onCopyCodeToClipboard function in amazonq Oct 31, 2024
@laileni-aws laileni-aws changed the title fix(amazonq): Regression using onCodeBlockActionClicked function, replaced with onCopyCodeToClipboard function in amazonq fix(amazonq): Regression using onCodeBlockActionClicked function, replaced with onCopyCodeToClipboard function in chat Oct 31, 2024
@laileni-aws laileni-aws marked this pull request as ready for review October 31, 2024 17:10
@laileni-aws laileni-aws requested review from a team as code owners October 31, 2024 17:10
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "Fix copyCodeToClipboard metric in amazonq chat"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not customer facing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect I will remove this

@laileni-aws
Copy link
Contributor Author

/retryBuilds

@laileni-aws laileni-aws merged commit fcb4f88 into aws:main Oct 31, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants