Skip to content

Conversation

@zixlin7
Copy link
Contributor

@zixlin7 zixlin7 commented Oct 31, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

This hint is inconsistent and might break selection on remote/gateway, so we will not show it for now on gateway

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zixlin7 zixlin7 requested a review from a team as a code owner October 31, 2024 20:20
@zixlin7 zixlin7 requested a review from a team as a code owner October 31, 2024 20:26
@zixlin7 zixlin7 requested a review from rli October 31, 2024 20:44
@zixlin7 zixlin7 enabled auto-merge (squash) October 31, 2024 20:51
class InlineChatSelectionListener : SelectionListener, Disposable {
private val inlineChatEditorHint = InlineChatEditorHint()
override fun selectionChanged(e: SelectionEvent) {
if (AppMode.isRemoteDevHost()) return

Check warning

Code scanning / QDJVMC

Unstable API Usage Warning

'com.intellij.idea.AppMode' is marked unstable with @ApiStatus.Internal
class InlineChatSelectionListener : SelectionListener, Disposable {
private val inlineChatEditorHint = InlineChatEditorHint()
override fun selectionChanged(e: SelectionEvent) {
if (AppMode.isRemoteDevHost()) return

Check warning

Code scanning / QDJVMC

Unstable API Usage Warning

'isRemoteDevHost()' is declared in unstable class 'com.intellij.idea.AppMode' marked with @ApiStatus.Internal
@zixlin7 zixlin7 merged commit 1b266b2 into aws:main Oct 31, 2024
12 of 13 checks passed
@zixlin7 zixlin7 deleted the hideHint branch October 31, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants