fix(amazonq): better location for inline chat editor hint #5057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zixlin7 could you put a screenshot of updated ui |
Will-ShaoHua
reviewed
Nov 6, 2024
...ns-community/src/software/aws/toolkits/jetbrains/services/cwc/inline/InlineChatEditorHint.kt
Outdated
Show resolved
Hide resolved
Will-ShaoHua
approved these changes
Nov 6, 2024
rli
approved these changes
Nov 7, 2024
|
|
||
| class InlineChatEditorHint { | ||
| private val hint = createHint() | ||
| private val hintXOffset = 20 |
There was a problem hiding this comment.
can you double check what happens when the UI is scaled really big?
There was a problem hiding this comment.
checked on both small window size and big monitor, it looks fine
dhasani23
pushed a commit
to ntarakad-aws/aws-toolkit-jetbrains
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
make the popup show at line end with some offset so it doesn't block code
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.