Fix metric for viewing Q auth webview #5061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

samgst-amazon merged 9 commits into main from samgst/QChatMetrics

Nov 14, 2024

Contributor

samgst-amazon commented Nov 7, 2024

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

Description

Re-implement Q auth metrics for open/close sign-in page that were removed in:
#4850

Checklist

My code follows the code style of this project
I have added tests to cover my changes
A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.


          metrics

119d32f

samgst-amazon requested a review from a team as a code owner

November 7, 2024 19:47


          detekt

9c40c09

github-actions bot commented Nov 7, 2024 •

edited

Loading

Qodana Community for JVM

4 new problems were found

Inspection name	Severity	Problems
`Usage of redundant or deprecated syntax or deprecated symbols`	🔶 Warning	4

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

github-advanced-security bot found potential problems

View reviewed changes

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt

    
              import software.aws.toolkits.jetbrains.settings.CodeWhispererSettings

              import software.aws.toolkits.jetbrains.utils.notifyError

              import software.aws.toolkits.resources.message

              import software.aws.toolkits.telemetry.AuthTelemetry

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

Remove deprecated symbol import

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt

    
              import software.aws.toolkits.jetbrains.settings.CodeWhispererSettings

              import software.aws.toolkits.jetbrains.utils.notifyError

              import software.aws.toolkits.resources.message

              import software.aws.toolkits.telemetry.AuthTelemetry

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'AuthTelemetry' is deprecated. Use type-safe metric builders

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt

    
                      fun recordCloseChat() {

                          Telemetry.amazonq.closeChat.use { it.passive(true) }

                          if (getQConnection() == null) {

                              AuthTelemetry.signInPageClosed()

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'AuthTelemetry' is deprecated. Use type-safe metric builders


          Merge branch 'main' into samgst/QChatMetrics

78156a7

samgst-amazon enabled auto-merge (squash)

November 7, 2024 21:16

samgst-amazon disabled auto-merge

November 7, 2024 21:16


          Merge branch 'main' into samgst/QChatMetrics

cf2062a

rli reviewed

View reviewed changes

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Outdated Show resolved Hide resolved

samgst-amazon added 2 commits

November 8, 2024 10:57


          project instance from call site

f09231a


          style

0b31d57

github-advanced-security bot found potential problems

View reviewed changes

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Fixed Show fixed Hide fixed

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt Fixed Show fixed Hide fixed

samgst-amazon added 2 commits

November 8, 2024 15:12


          fix indents

244a198


          Merge branch 'main' into samgst/QChatMetrics

d1643fb

github-advanced-security bot found potential problems

View reviewed changes

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt

    
                      fun recordOpenChat(project: Project) {

                          Telemetry.amazonq.openChat.use { it.passive(true) }

                          if (getQConnection(project) == null) {

                              AuthTelemetry.signInPageOpened()

Check warning

Code scanning / QDJVMC

Usage of redundant or deprecated syntax or deprecated symbols Warning

'AuthTelemetry' is deprecated. Use type-safe metric builders


          detekt

b937967

rli reviewed

View reviewed changes

...rc/software/aws/toolkits/jetbrains/services/cwc/controller/chat/telemetry/TelemetryHelper.kt

Comment on lines 422 to +425

    
                          Telemetry.amazonq.openChat.use { it.passive(true) }

                          if (getQConnection(project) == null) {

                              AuthTelemetry.signInPageOpened()

                          }

Contributor

rli Nov 11, 2024

should this be

Suggested change

      
                        Telemetry.amazonq.openChat.use { it.passive(true) }
          
                        if (getQConnection(project) == null) {
          
                            AuthTelemetry.signInPageOpened()
          
                        }
          
                        if (getQConnection(project) == null) {
          
                            AuthTelemetry.signInPageOpened()
          
                        } else {
          
                            Telemetry.amazonq.openChat.use { it.passive(true) }
          
                        }

Contributor Author

samgst-amazon Nov 12, 2024

it looks like vsc emits these separately. openChat is ambiguously: "When user opens CWSPR chat panel".

separating these metrics would make open/close chat a little more meaningful.

rli approved these changes

View reviewed changes

samgst-amazon merged commit 141b6ca into main

15 of 17 checks passed

samgst-amazon deleted the samgst/QChatMetrics branch

November 14, 2024 19:35

dhasani23 pushed a commit to ntarakad-aws/aws-toolkit-jetbrains that referenced this pull request


          Fix metric for viewing Q auth webview (aws#5061)

3cadeb3

* metrics

* detekt

* project instance from call site

* style

* fix indents

* detekt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet