fix(amazonq): Amazon Q chat should not mention indexing in progress when indexing finished #5062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leigaol
changed the title
Will-ShaoHua
reviewed
Nov 7, 2024
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/project/ProjectContextProvider.kt
Outdated
Show resolved
Hide resolved
Will-ShaoHua
approved these changes
Nov 7, 2024
| val url = URL("http://localhost:${encoderServer.port}/${msgType.endpoint}") | ||
|
|
||
| // use 1h as timeout for index, 5 seconds for other APIs | ||
| val timeoutMs = if (msgType is LspMessage.Index) 60.minutes.inWholeMilliseconds.toInt() else 5000 |
Contributor
There was a problem hiding this comment.
can/should these be enum?
Contributor
Author
There was a problem hiding this comment.
timeoutMs can only be integer.
rli
approved these changes
Nov 8, 2024
Contributor
|
/retryBuilds |
dhasani23
pushed a commit
to ntarakad-aws/aws-toolkit-jetbrains
that referenced
this pull request
Nov 18, 2024
…hen indexing finished (aws#5062) * adjust LSP API timeout * update time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Fix a bug when Amazon Q responds with still indexing message even when
@workspaceindex is doneChecklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.