Skip to content

Conversation

@andrewyuq
Copy link
Contributor

@andrewyuq andrewyuq commented Nov 12, 2024

  1. Auto-trigger now triggers much more frequently and suggestions will consistently show whenever user stops typing.
    The key shortcuts for Q inline suggestions are now configurable from the keymap settings. Default key shortcut for force accept is option + tab or option + enter and default for navigation keys has now changed from <- (navigating to prev) and -> (navigating to next) arrow keys to option + [ and option + ] , respectively.
  2. Amazon Q suggestions can now co-exist with JetBrains code completions (IntelliSense). When both suggestions appear on the screen, tab accepts JetBrains suggestions first. Users will also have other key shortcuts to force accept the other Q suggestion (option + tab or option + enter)
  3. The Amazon Q suggestion popup is now hidden by default and only appears above the current editing line when the user hovers over the suggestion preview text. IntelliSense popup (if it's showing) will also appear to be more transparent when user hovers over the suggestion preview.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andrewyuq andrewyuq requested review from a team as code owners November 12, 2024 19:57
startTime = endTime
val requestId = response.responseMetadata().requestId()
val sessionId = response.sdkHttpResponse().headers().getOrDefault(KET_SESSION_ID, listOf(requestId))[0]
if (requestCount == 1) {

Check warning

Code scanning / QDJVMC

Constant conditions Warning

Condition 'requestCount == 1' is always true
LOG.debug { "Skipping sending remaining requests on inactive CodeWhisperer session exit" }
return
}
if (requestCount >= PAGINATION_REQUEST_COUNT_ALLOWED) {

Check warning

Code scanning / QDJVMC

Constant conditions Warning

Condition 'requestCount >= PAGINATION_REQUEST_COUNT_ALLOWED' is always true
runInEdt {
HintManager.getInstance().showInformationHint(editor, message, HintManager.UNDER)
}
fun showCodeWhispererInfoHint(editor: Editor, message: String) {

Check notice

Code scanning / QDJVMC

Class member can have 'private' visibility Note

Function 'showCodeWhispererInfoHint' could be private
runInEdt {
HintManager.getInstance().showErrorHint(editor, message, HintManager.UNDER)
}
fun showCodeWhispererErrorHint(editor: Editor, message: String) {

Check notice

Code scanning / QDJVMC

Class member can have 'private' visibility Note

Function 'showCodeWhispererErrorHint' could be private
@andrewyuq andrewyuq changed the title Feature: Introduce auto trigger changes officially feat(amazonq): Introduce auto trigger changes officially Nov 13, 2024
@andrewyuq andrewyuq merged commit b01283e into aws:main Nov 21, 2024
11 checks passed
andrewyuq added a commit to andrewyuq/aws-toolkit-jetbrains that referenced this pull request Nov 25, 2024
andrewyuq added a commit that referenced this pull request Nov 26, 2024
* Revert "Fix perceivedLatency to set it for only 1 trigger per display session (#5118)"

This reverts commit 364305e.

* Revert "feat(amazonq): Introduce auto trigger changes officially (#5080)"

This reverts commit b01283e.

---------

Co-authored-by: Lei Gao <[email protected]>
karanA-aws pushed a commit to karanA-aws/aws-toolkit-jetbrains that referenced this pull request Jan 22, 2025
* Revert "Fix perceivedLatency to set it for only 1 trigger per display session (aws#5118)"

This reverts commit 364305e.

* Revert "feat(amazonq): Introduce auto trigger changes officially (aws#5080)"

This reverts commit b01283e.

---------

Co-authored-by: Lei Gao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants