add more telemetry info for NoSuchFileException failures #5087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
manodnyab
reviewed
Nov 14, 2024
| LOG.info { "Failed to load Client Registration: cache file does not exist" } | ||
|
|
||
| val path = clientRegistrationCache(cacheKey) | ||
| val fileExists = path.exists() |
Contributor
There was a problem hiding this comment.
Dont we already know that the file doesn't exist here
Contributor
There was a problem hiding this comment.
Would we get an error other than NoSuchFileException?
Contributor
Author
There was a problem hiding this comment.
I think you're right. I think the permissions errors are being handled correctly so this may not be what's needed
| val stage = LoadCredentialStage.ACCESS_FILE | ||
| LOG.info { "Failed to load Client Registration: cache file does not exist" } | ||
|
|
||
| val path = clientRegistrationCache(cacheKey) |
Contributor
There was a problem hiding this comment.
Can we reuse the value above?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
added information to modifyConnection's reason description to report whether a file actually doesn't exist or if the user is missing permissions.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.