fix(amazonq): @workspace command shown in all tab types
#5089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilk-aws
approved these changes
Nov 14, 2024
rli
changed the title
@workspace command shown in all tab types
rli
reviewed
Nov 14, 2024
.changes/next-release/bugfix-0150eb94-2d05-40f5-8473-b2ee1fd6bf09.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Richard Li <[email protected]>
dhasani23
pushed a commit
to ntarakad-aws/aws-toolkit-jetbrains
that referenced
this pull request
Nov 18, 2024
The `@workspace` [context command](https://github.com/aws/mynah-ui/blob/main/docs/DATAMODEL.md#contextcommands-default-) is being shown in all tab types, even though it is only relevant to Amazon Q chat ('cwc' tabType).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Problem
The
@workspacecontext command is being shown in all tab types, even though it is only relevant to Amazon Q chat ('cwc' tabType).Solution
Update getTabData function to allow each tab type to specify its own contextCommands
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.