Setting customization name to AB variation for display in status bar #5090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spfink
force-pushed
the
finks/override
branch
from
1bf6a04 to
da19ceb
Compare
rli
approved these changes
Nov 15, 2024
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type" : "feature", | |||
| "description" : "Uses AB variation as the name for overriden customizations" | |||
Contributor
There was a problem hiding this comment.
maybe bug fix: fix issue where incorrect customization is shown when local setting is overridden by the amazon q service
Contributor
Author
There was a problem hiding this comment.
We didn't really have a contract for how we plumb this additional data through so marked it as a feature because it's new but could go either way
spfink
force-pushed
the
finks/override
branch
from
68d41c8 to
e225cdc
Compare
|
|
||
| fun getCustomizationArnOverride(): String = getFeatureValueForKey(CUSTOMIZATION_ARN_OVERRIDE_NAME).stringValue() | ||
|
|
||
| fun getCustomizationOverrideName(): String = getFeatureVariationForKey(CUSTOMIZATION_ARN_OVERRIDE_NAME) |
Contributor
There was a problem hiding this comment.
can we merge these 2 methods
Contributor
Author
There was a problem hiding this comment.
Updated with a generic method
Comment on lines
128
to
126
| private fun getFeatureVariationForKey(name: String): String = | ||
| featureConfigs[name]?.variation.orEmpty() | ||
|
|
Contributor
There was a problem hiding this comment.
should have a generic one instead
private fun getFeature(k: String): FeatureContext = featureConfigs[k]
spfink
force-pushed
the
finks/override
branch
from
e605d0e to
e1a4c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
When a customizationArnOverride is present from an AB feature response, the toolkit will currently default to displaying the name of the last selected customization by the user rather than a name for the customization that was overridden. With this change, we'll use the AB variation field to specify a name for the customizationArn override and use it for display.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.