Skip to content

Conversation

@dhasani23
Copy link
Contributor

@dhasani23 dhasani23 commented Nov 20, 2024

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dhasani23 dhasani23 requested a review from a team as a code owner November 20, 2024 08:07
@dhasani23
Copy link
Contributor Author

dhasani23 commented Nov 20, 2024

Note: I may add a feature flag around this SQL Conversions feature in this PR too, will let you know by the early afternoon of Wednesday 11/20, if so I should also remove the CHANGELOG entry.

codemodernizer.chat.message.button.view_failure_build_log=View Failure Build Log
codemodernizer.chat.message.button.view_summary=View summary
codemodernizer.chat.message.choose_objective=Enter "language upgrade" or "SQL conversion"
codemodernizer.chat.message.choose_objective=I can help you with the following tasks:\n- Upgrade your Java 8 and Java 11 codebases to Java 17, or upgrade Java 17 code with up to date libraries and other dependencies.\n- Convert embedded SQL code for Oracle to PostgreSQL database migrations in AWS DMS.\n\nWhat would you like to do? You can enter "language upgrade" or "sql conversion".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
codemodernizer.chat.message.choose_objective=I can help you with the following tasks:\n- Upgrade your Java 8 and Java 11 codebases to Java 17, or upgrade Java 17 code with up to date libraries and other dependencies.\n- Convert embedded SQL code for Oracle to PostgreSQL database migrations in AWS DMS.\n\nWhat would you like to do? You can enter "language upgrade" or "sql conversion".
codemodernizer.chat.message.choose_objective=I can help you with the following tasks:\n- Upgrade your Java 8 and Java 11 codebases to Java 17, or upgrade Java 17 code with up-to-date libraries and other dependencies.\n- Convert embedded SQL code for Oracle to PostgreSQL database migrations in AWS DMS.\n\nWhat would you like to do? You can enter "language upgrade" or "sql conversion".

nit: up-to-date is hyphenated when used as an adjective

@dhasani23
Copy link
Contributor Author

Update: this PR is good to merge, no more changes expected as of 11:30am 11/20

@dhasani23 dhasani23 merged commit 5b5f994 into aws:main Nov 20, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants