-
Notifications
You must be signed in to change notification settings - Fork 275
Add framework for processing notifications #5112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // Copyright 2024 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| package software.aws.toolkits.jetbrains.core.notifications | ||
|
|
||
| class ProcessNotificationsBase { | ||
| init { | ||
|
Check notice on line 7 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
Check noticeCode scanning / QDJVMC Redundant empty initializer block Note
Redundant empty initializer block
|
||
| // TODO: install a listener for the polling class | ||
| } | ||
|
Check warning on line 9 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
|
|
||
| fun getNotificationsFromFile() { | ||
Check warningCode scanning / QDJVMC Unused symbol Warning
Function "getNotificationsFromFile" is never used
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. isnt this what the poller should be doing?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, the poller will deserialize to check if well formed, but we will need to pull the notifications in anyway to call the separation of lists function. This function is optional and can be moved to the poller class too. Would prefer keeping it here to keep track of all the processing bit in the same class.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Merging this in for now, @samgst-amazon will modify the location later, if required! |
||
| // TODO: returns a notification list | ||
| } | ||
|
Check warning on line 13 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
|
|
||
| fun retrieveStartupAndEmergencyNotifications() { | ||
|
Check warning on line 15 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
Check warningCode scanning / QDJVMC Unused symbol Warning
Function "retrieveStartupAndEmergencyNotifications" is never used
|
||
| // TODO: separates notifications into startup and emergency | ||
| // iterates through the 2 lists and processes each notification(if it isn't dismissed) | ||
| } | ||
|
Check warning on line 18 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
|
|
||
| fun processNotification() { | ||
Check warningCode scanning / QDJVMC Unused symbol Warning
Function "processNotification" is never used
|
||
| // TODO: calls the Rule engine and notifies listeners | ||
| } | ||
|
Check warning on line 22 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
|
|
||
| fun notifyListenerForNotification() { | ||
Check warningCode scanning / QDJVMC Unused symbol Warning
Function "notifyListenerForNotification" is never used
|
||
| } | ||
|
Check warning on line 25 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
|
|
||
| fun addListenerForNotification() { | ||
Check warningCode scanning / QDJVMC Unused symbol Warning
Function "addListenerForNotification" is never used
|
||
| } | ||
|
Check warning on line 28 in plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/notifications/ProcessNotificationsBase.kt
|
||
| } | ||
Check warning
Code scanning / QDJVMC
Unused symbol Warning