Fix: catch error when notification file is not found #5157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Working on a better implementation of the Resource Resolver for notification polling but this should handle #5150 |
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
rli
approved these changes
Dec 3, 2024
| } | ||
| return NotificationMapperUtil.mapper.readValue(content) | ||
| } catch (e: Exception) { | ||
| LOG.warn { "Error reading notifications file: $e" } |
Contributor
There was a problem hiding this comment.
would prefer to fix the underlying issue
willyyhuang
pushed a commit
that referenced
this pull request
Dec 4, 2024
* handle uncaught error * detekt
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
* handle uncaught error * detekt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NoSuchFileException handling during notification processing fails gracefully instead of bubbling up to an IDE error.
Types of changes
Description
Fix an issue where if there is no notification file in the cache, notification retrieval fails silently instead of bubbling up an exception
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.