use RemoteResourceResolver in notification polling for etag and PATH handling #5165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
...unity/src/software/aws/toolkits/jetbrains/core/notifications/NotificationResourceResolver.kt
Fixed
Show fixed
Hide fixed
rli
reviewed
Dec 6, 2024
|
|
||
| private fun getEndpointETag(): String = | ||
| try { | ||
| HttpRequests.request(NotificationEndpoint.getEndpoint()) |
Contributor
There was a problem hiding this comment.
use a HEAD request if all you are interested in is the headers of GET
| data object FirstPollCheck : UpdateCheckResult() | ||
| } | ||
|
|
||
| class NotificationResourceResolver( |
Contributor
There was a problem hiding this comment.
lets fold this into DefaultRemoteResourceResolver because there is nothing special about etag handling
rli
reviewed
Dec 9, 2024
| private fun getEndpointETag(endpoint: String): String = | ||
| try { | ||
| val url = URI(endpoint).toURL() | ||
| (url.openConnection() as HttpURLConnection).let { connection -> |
Contributor
There was a problem hiding this comment.
java 11 has a newer way of doing this, but let's actually use the HttpRequests util you were using in a previous PR
| complete(file) | ||
| } | ||
|
|
||
| // following two methods are not used in this test, make compiler happy |
Contributor
There was a problem hiding this comment.
you can simply just define a default implementation in the interface if this is the generic no-op implementation
|
|
||
| override fun checkForUpdates(endpoint: String, eTagProvider: ETagProvider): UpdateCheckResult { | ||
| val hasETagUpdate = updateETags(eTagProvider, endpoint) | ||
| // for when we need to notify on first poll even when there's no new ETag |
Contributor
There was a problem hiding this comment.
it would make more sense to see if ETagProvider has a value set to determine if this were the first request
rli
approved these changes
Dec 9, 2024
laileni-aws
pushed a commit
to laileni-aws/aws-toolkit-jetbrains
that referenced
this pull request
Dec 12, 2024
…handling (aws#5165) * always fetch from endpoint during poll * notification resource resolver * ResourceResolver etag handling * codescan * remove redundant modifier * move functionality to DefaultRemoteResourceResolver * implement defaultRemoteResourceResolverProvider instead * url deprecated * detekt * detektTest fix mock functions * detekt * default function in interface * re-implement HTTPRequest * re-implement HTTPRequest * ETag fix * LazyLogRule
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
…handling (aws#5165) * always fetch from endpoint during poll * notification resource resolver * ResourceResolver etag handling * codescan * remove redundant modifier * move functionality to DefaultRemoteResourceResolver * implement defaultRemoteResourceResolverProvider instead * url deprecated * detekt * detektTest fix mock functions * detekt * default function in interface * re-implement HTTPRequest * re-implement HTTPRequest * ETag fix * LazyLogRule
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
…handling (aws#5165) * always fetch from endpoint during poll * notification resource resolver * ResourceResolver etag handling * codescan * remove redundant modifier * move functionality to DefaultRemoteResourceResolver * implement defaultRemoteResourceResolverProvider instead * url deprecated * detekt * detektTest fix mock functions * detekt * default function in interface * re-implement HTTPRequest * re-implement HTTPRequest * ETag fix * LazyLogRule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement custom RemoteResourceResolver for notification logic to handle ETag fetching and providing the path to the local resource.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.