Adds capability to send new context commands to AB groups #5206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
approved these changes
Dec 13, 2024
Comment on lines
122
to
124
| console.log("finkscommand") | ||
| console.log(this.highlightCommand) | ||
| console.log("end") |
Contributor
There was a problem hiding this comment.
Suggested change
| console.log("finkscommand") | |
| console.log(this.highlightCommand) | |
| console.log("end") |
| $isCodeScanAvailable, // whether /scan is available | ||
| $isCodeTestAvailable // whether /test is available | ||
| $isCodeTestAvailable, // whether /test is available | ||
| ${jacksonObjectMapper().writeValueAsString(highlightCommand)} |
Contributor
There was a problem hiding this comment.
can you bump the jacksonObjectMapper() to the companion object as a private val so it can be reused?
| listOf( | ||
| FeatureEvaluation.builder() | ||
| .feature(CodeWhispererFeatureConfigService.CUSTOMIZATION_ARN_OVERRIDE_NAME) | ||
| .feature("customizationArnOverride") |
Contributor
Author
There was a problem hiding this comment.
All of the other feature consts were made private so moved this to private which required the hardcoded value
Contributor
There was a problem hiding this comment.
i feel it's not necessary to make the experiemtn names private tho, we should be good as long as they are const.
Contributor
There was a problem hiding this comment.
it's easier to restructure and refactor featureConfigService to simply use enum as experiment, but it's not blocker for the PR
spfink
force-pushed
the
finks/highlight-commands
branch
3 times, most recently
from
e0de036 to
d477438
Compare
Will-ShaoHua
approved these changes
Dec 14, 2024
spfink
force-pushed
the
finks/highlight-commands
branch
from
d477438 to
8af14d2
Compare
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
Add the ability to send a new command that will appear when a user types @ in the chat window
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
Add the ability to send a new command that will appear when a user types @ in the chat window
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to send a new command that will appear when a user types @ in the chat window
Types of changes
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.