Preserve file permissions in the zip archive, fix bugs in gitignore matching and keep mvm and gradle files #5224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ore mattern matching and keep mvm and gradle files
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/FeatureDevSessionContext.kt
Fixed
Show fixed
Hide fixed
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/FeatureDevSessionContext.kt
Fixed
Show fixed
Hide fixed
neilk-aws
approved these changes
Jan 3, 2025
manodnyab
reviewed
Jan 3, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type" : "bugfix", | |||
| "description" : "Preserve file permissions in the zip archive, fix bugs in gitignore matching and keep mvm and gradle files" | |||
Contributor
There was a problem hiding this comment.
Is the change user facing, ie is a changelog required here?
Contributor
Author
There was a problem hiding this comment.
yep, it does have a user facing change. updated the messaging.
| val file = Files.createTempFile(null, ".zip") | ||
| ZipOutputStream(file.outputStream()).use { zipOutput -> block(zipOutput) } | ||
| file | ||
| private suspend fun createTemporaryZipFileAsync(block: suspend (FileSystem) -> Unit): Path = withContext(EDT) { |
Contributor
There was a problem hiding this comment.
Should this be on the background thread?
Contributor
Author
There was a problem hiding this comment.
good call, changed it to run on background
...s-community/src/software/aws/toolkits/jetbrains/services/amazonq/FeatureDevSessionContext.kt
Fixed
Show fixed
Hide fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserve file permissions in the zip archive, fix bugs in gitignore matching and keep mvm and gradle files
Types of changes
Description
ZipOutputStreamdoesn't include file permission when archiving. Switching to ZipFS to be able to preserve the permissions on the archivessettings.gradlefile being ignored due to.gradlerule in gitignore. Changed the logic to fix it.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.