telemetry(amazonq): combine metrics #5227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhasani23
commented
Jan 3, 2025
| private var totalPatchFiles: Int = 0 | ||
| private var sharedPatchIndex: Int = 0 | ||
|
|
||
| internal suspend fun displayDiff(job: JobId, source: CodeTransformVCSViewerSrcComponents) { |
Contributor
Author
There was a problem hiding this comment.
Removed source because it's not useful to us
added 3 commits
January 2, 2025 19:11
ntarakad-aws
approved these changes
Jan 6, 2025
manodnyab
reviewed
Jan 6, 2025
| codeTransformMetadata = metaData.toString(), | ||
| codeTransformSessionId = sessionId, | ||
| reason = reason, | ||
| result = if (success) MetricResult.Succeeded else MetricResult.Failed, |
Contributor
There was a problem hiding this comment.
Would recommend using Result.Succeeded and Result.Failed here
Contributor
Author
There was a problem hiding this comment.
I saw that Result is deprecated in favor of MetricResult
manodnyab
approved these changes
Jan 6, 2025
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 17, 2025
* telemetry(amazonq): combine metrics * remove unneeded field * re-run CI * remove unused property * fix detekt --------- Co-authored-by: David Hasani <[email protected]>
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-jetbrains
that referenced
this pull request
Jan 22, 2025
* telemetry(amazonq): combine metrics * remove unneeded field * re-run CI * remove unused property * fix detekt --------- Co-authored-by: David Hasani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Just use
submitSelection;viewArtifactis redundant.Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.