Skip to content

Conversation

@Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented Jan 14, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Introduce repomap fetching to on top of the existing opentabs context

  1. when both repomap and opentabs are present, send both to the service and repomap has to be the 1st item in the list with strategy name codemap
  2. when only either 1 of them is present, send the one who is present with strategy name either opentabs or codemap
  3. None of them exist will be empty
  • the 2 types of context are fetched by the plugin and workspace context subprocess concurrently
  • total length of context should not exceed 20480 cap
  • the entire supplemental context fetching is budget within 100 ms

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua
Copy link
Contributor Author

/retryBuilds

@Will-ShaoHua Will-ShaoHua requested a review from leigaol January 14, 2025 18:21
@Will-ShaoHua Will-ShaoHua changed the title enhance inline completion supplemental context fetching feat(inline completion): enhance inline completion supplemental context fetching Jan 14, 2025
Comment on lines +333 to +334
while (c.sumOf { it.content.length } >= CodeWhispererConstants.CrossFile.MAX_TOTAL_LENGTH) {
c = c.dropLast(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice, but maybe optimize

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea agreeeeeeeee

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me follow up on it


enum class InlineContextTarget(private val v: String) {
CODEMAP("codemap"),
BM25("bm25"),

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "BM25" is never used
enum class InlineContextTarget(private val v: String) {
CODEMAP("codemap"),
BM25("bm25"),
DEFAULT("default"), ;

Check warning

Code scanning / QDJVMC

Unused symbol Warning

Class "DEFAULT" is never used
Will-ShaoHua added a commit to aws/aws-toolkit-vscode that referenced this pull request Jan 14, 2025
…6356)

## Problem
corresponding JB change
aws/aws-toolkit-jetbrains#5256 (vscode logics
has been implemented)



## Solution


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
@Will-ShaoHua Will-ShaoHua enabled auto-merge (squash) January 14, 2025 22:46
@Will-ShaoHua Will-ShaoHua merged commit 3e1e995 into aws:main Jan 14, 2025
11 checks passed
avi-alpert pushed a commit to avi-alpert/aws-toolkit-vscode that referenced this pull request Jan 15, 2025
…ws#6356)

## Problem
corresponding JB change
aws/aws-toolkit-jetbrains#5256 (vscode logics
has been implemented)



## Solution


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
karanA-aws pushed a commit to karanA-aws/aws-toolkit-jetbrains that referenced this pull request Jan 17, 2025
karanA-aws pushed a commit to karanA-aws/aws-toolkit-vscode that referenced this pull request Jan 17, 2025
…ws#6356)

## Problem
corresponding JB change
aws/aws-toolkit-jetbrains#5256 (vscode logics
has been implemented)



## Solution


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
karanA-aws pushed a commit to karanA-aws/aws-toolkit-jetbrains that referenced this pull request Jan 22, 2025
kevluu-aws pushed a commit to kevluu-aws/aws-toolkit-vscode that referenced this pull request Jan 23, 2025
…ws#6356)

## Problem
corresponding JB change
aws/aws-toolkit-jetbrains#5256 (vscode logics
has been implemented)



## Solution


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
s7ab059789 pushed a commit to s7ab059789/aws-toolkit-vscode that referenced this pull request Feb 19, 2025
…ws#6356)

## Problem
corresponding JB change
aws/aws-toolkit-jetbrains#5256 (vscode logics
has been implemented)



## Solution


---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants