- 
                Notifications
    
You must be signed in to change notification settings  - Fork 273
 
fix(/dev): Exclude gradle-wrapper.jar and add separate build commands #5266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Closed
      
      
            karanA-aws
  wants to merge
  116
  commits into
  aws:feature/dev-execution
from
karanA-aws:feature/dev-execution
  
      
      
   
      
    
  
     Closed
                    Changes from 2 commits
      Commits
    
    
            Show all changes
          
          
            116 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      737c56b
              
                feat: allow install, build, and test commands separately
              
              
                karanA-aws 63765fe
              
                Exclude gradle-wrapper.jar from .gitignore checks
              
              
                karanA-aws d845d43
              
                Exclude gradle-wrapper.jar from .gitignore checks
              
              
                karanA-aws aeb328b
              
                feat(amazonq): support Dockerfile files in /dev (#5131)
              
              
                michaellandi 3b2133c
              
                config(amazonq): enable implicit project context ab test (#5124)
              
              
                Will-ShaoHua f37dd26
              
                fix(amazonq): download each job's zip to its own directory (#5134)
              
              
                dhasani23 ae089d5
              
                fix(amazonq): Normalize generated file paths in feature dev. (#5130)
              
              
                ctidd e0e6c39
              
                fix(amazonq): Correct search text for Amazon Q inline suggestion keyb…
              
              
                leigaol 7e52360
              
                Updating version to 3.42
              
              
                 d5a00b2
              
                Updating SNAPSHOT version to 3.43-SNAPSHOT
              
              
                 56b61d4
              
                Display startup and emergency notifications (#5143)
              
              
                samgst-amazon d101adb
              
                Fix notification polling race condition (#5142)
              
              
                samgst-amazon f442fb9
              
                changelog for #5143 (#5146)
              
              
                samgst-amazon 86b5a21
              
                re:Invent 2024
              
              
                samgst-amazon 876d99e
              
                Updating version to 3.43
              
              
                 70dc5af
              
                Updating SNAPSHOT version to 3.44-SNAPSHOT
              
              
                 b3b8bf8
              
                Fix 'ActionGroup should be registered using <group> tag' (#5147)
              
              
                rli 943e9d3
              
                Fix marketplace description incorrectly referring to `/docs` (#5154)
              
              
                rli 41e7aef
              
                Clean up Q explore UX (#5153)
              
              
                rli f8da96c
              
                Fix wildcard import rule allowing java.util.* (#5155)
              
              
                rli f8d274a
              
                Fix for Code Fix issue description.
              
              
                ashishrp-aws a34c809
              
                Dedupe open tab logic / fix Q Review tab always using same UUID
              
              
                rli ec1cb9a
              
                revert
              
              
                rli ffc8926
              
                Adding credentialUrl to differentiate the Internal Users vs External …
              
              
                laileni-aws 654ee62
              
                fix npm dev dependency issues (#5158)
              
              
                rli dd44dc3
              
                Fix: catch error when notification file is not found (#5157)
              
              
                samgst-amazon 6f3b2e6
              
                Fix Code Transform not starting (#5160)
              
              
                rli 755ca34
              
                Updating version to 3.44
              
              
                 99fafba
              
                Updating SNAPSHOT version to 3.45-SNAPSHOT
              
              
                 8ca9e89
              
                Replaced @aws/dexp by @aws/flare in codeowners, as part of the dexp r…
              
              
                Jurredr f586668
              
                fix(amazonq): missing `@workspace` command on welcome tab (#5164)
              
              
                rli d22a01a
              
                fix(amazonq): Fix for File Review payload and payload generation erro…
              
              
                ashishrp-aws 66817bc
              
                Fix for codeScanFilterGroup and Filter Icon error. (#5172)
              
              
                ashishrp-aws 08b95f3
              
                fix(amazonq): Fix for LLM based code issues for file review on window…
              
              
                ashishrp-aws 2348fcd
              
                fix: Chosing cancel on confirmation no longer deletes profiles (#5167…
              
              
                rickardsundin 5c52975
              
                Limit number of times user is given Q welcome page (#5152)
              
              
                rli d4f4a3a
              
                Update notification endpoint (#5177)
              
              
                samgst-amazon cf47357
              
                feat(amazonq): Add acknowledgement button for disclaimer (#5178)
              
              
                rli 0d74803
              
                Adding requestId for amazonq_utgGenerateTests event (#5181)
              
              
                laileni-aws a6d3f96
              
                notification success telemetry (#5179)
              
              
                samgst-amazon 424d05f
              
                fix(amazonq): show build logs when pre-build fails (#5173)
              
              
                dhasani23 59bd5bd
              
                adding telemetry at time of form selection for one or multiple diffs …
              
              
                ntarakad-aws 205deed
              
                fix(amazon q): adding the start new transformation button after multi…
              
              
                ntarakad-aws e458328
              
                fix(amazonq): don't call stopJob API if no job active (#5174)
              
              
                dhasani23 b0d9f3c
              
                Updating version to 3.45
              
              
                 ec529a9
              
                Updating SNAPSHOT version to 3.46-SNAPSHOT
              
              
                 a03167c
              
                Fix rejected files display inconsistency between VS Code and JetBrain…
              
              
                siakmun-aws ac8bc2b
              
                Limit concurrency of prerelease task (#5184)
              
              
                rli f9365ce
              
                Add regression test for EDT freeze when Q creds are expired (#4891)
              
              
                rli 10bcceb
              
                fix(amazonq): reduce frequency of system information polling (#5190)
              
              
                leigaol a13ac32
              
                use RemoteResourceResolver in notification polling for etag and PATH …
              
              
                samgst-amazon 9c2ba98
              
                build(deps): bump nanoid from 3.3.7 to 3.3.8 in /plugins/core/webview…
              
              
                dependabot[bot] 9569788
              
                fix: move file name to description (#5195)
              
              
                ctlai95 69f7c2e
              
                fix(amazonq): align /doc messages with vscode (#5191)
              
              
                aggagen cdf1514
              
                Fix chat not retaining history when interaction is through onboarding…
              
              
                rli aecb648
              
                feat(amazonq): automatically scroll to fix section (#5198)
              
              
                ctlai95 705e6ed
              
                fix(amazonq): clicking on generated test file does not open file diff…
              
              
                Randall-Jiang d75f8fb
              
                Fix SSM integ tests (#5202)
              
              
                rli 829d470
              
                build(deps): bump nanoid in /plugins/amazonq/mynah-ui (#5204)
              
              
                dependabot[bot] 1027cf2
              
                Update Mynah UI to 4.21.2 (#5203)
              
              
                rli 8aa8c74
              
                telemetry(amazonq): generateFix metric result (#5199)
              
              
                ctlai95 16b0c61
              
                Adds capability to send new context commands to AB groups (#5206)
              
              
                spfink 9929c9f
              
                Updating version to 3.46
              
              
                 70dc24c
              
                Updating SNAPSHOT version to 3.47-SNAPSHOT
              
              
                 321ccd8
              
                fix(amazonq): allow postgresql as target DB (#5209)
              
              
                dhasani23 f4d0ce7
              
                chore: Align UX text of document generation with vs code version (#5212)
              
              
                KevinDing1 6f75ea1
              
                fix(amazonq): retry S3 upload (#5208)
              
              
                dhasani23 8bc0f9a
              
                Move IntelliJ Gradle plugin to 2.2.1 (#5213)
              
              
                rli d6c114e
              
                telemetry(amazonq): add metric for transformation type (#5218)
              
              
                dhasani23 355a905
              
                telemetry(amazonq): sending metric data in onCodeGeneration (#5205)
              
              
                siakmun-aws 6c056fb
              
                fix(amazonq): use correct doc link (#5223)
              
              
                dhasani23 f90ab2b
              
                Hide notifications is plugin mentioned in the conditions is not insta…
              
              
                manodnyab f17c571
              
                telemetry(amazonq): map to the correct scope (#5210)
              
              
                ctlai95 8214433
              
                telemetry(amazonq): combine metrics (#5227)
              
              
                dhasani23 74e279f
              
                Fix(core): State storage roaming type set to default for notification…
              
              
                samgst-amazon a0bc4a1
              
                fix(amazonq): Skip including deleted files for FeatureDev context. (#…
              
              
                ctidd 94f08bd
              
                Change logic for customization override to not override if user has m…
              
              
                spfink aa431d6
              
                fix(amazonq): Correct amazon q documentation updating flow progress t…
              
              
                KevinDing1 c21435f
              
                add JetBrains IdeCategory for enterprise telemetry (#5238)
              
              
                chungjac 82a660b
              
                fix(amazonq): /test fails for files outside project scope (#5237)
              
              
                ashishrp-aws fedb74a
              
                Set expiry for dismissed notifications (#5186)
              
              
                samgst-amazon 3082a93
              
                telemetry(amazonq): remove amazonq_utgGenerateTests metric override (…
              
              
                chungjac a18afbb
              
                Fix for Test generation active file info file path check on windows. …
              
              
                ashishrp-aws 251c57c
              
                fix: remove the incorrect accept and reject buttons while hovering ov…
              
              
                KevinDing1 a0599e9
              
                Fix JSR310 serialization error when preparing login panel (#5216)
              
              
                rli fc4896c
              
                rename projectContextProvider.query to queryChat (#5234)
              
              
                Will-ShaoHua af7f5d5
              
                Updating version to 3.47
              
              
                 4afc90c
              
                Updating SNAPSHOT version to 3.48-SNAPSHOT
              
              
                 823f0cc
              
                fix(amazonq): update messaging for /doc (#5243)
              
              
                vikshe 5bea616
              
                chore: remove unused telemetry method for /doc (#5248)
              
              
                KevinDing1 1273a14
              
                fix(amazonq): minor string updates (#5245)
              
              
                dhasani23 32153f7
              
                fix(amazonq): add retry on IOException (#5246)
              
              
                dhasani23 1448021
              
                Fix test failures caused by mockk not cleaning up (#5207)
              
              
                rli ff1226e
              
                fix(amazonq): Fix code generation error when cancelling /doc task (#5…
              
              
                aggagen a5487bc
              
                fix(amazonq): auto open build logs (#5255)
              
              
                dhasani23 92fe25c
              
                fix(amazonq): add follow up button (#5251)
              
              
                dhasani23 56955c8
              
                feat(amazonq): add error message if updated README is too large (#5253)
              
              
                avi-alpert 430fcc9
              
                fix(amazonqDoc): Generate README for modules that are a part of the p…
              
              
                mattmcdonald39 9ba0b6e
              
                fix(amazonq): Error handling and telemetry for Unit test generation. …
              
              
                laileni-aws 3491254
              
                fix(amazonq): add link to docs (#5257)
              
              
                dhasani23 e07578b
              
                fix(amazonq): file premissions are now preserved and mvn and gradle f…
              
              
                osdemah 6e8795b
              
                feat(inline completion): enhance inline completion supplemental conte…
              
              
                Will-ShaoHua a2c0f70
              
                fix(amazonq): loosen search strings (#5260)
              
              
                dhasani23 f9bacc4
              
                change active file context limit to 40000(20k before & after) (#5262)
              
              
                andrewyuq 63dfe3a
              
                fix(amazonq): rely on server-side data to communicate number of code …
              
              
                siakmun-aws 9c00012
              
                Telemetry(amazonq): Discrepancy between NumOfUnitTestCasesGenerated w…
              
              
                Randall-Jiang 916c2d3
              
                telemetry(amazonq): invalid zip event (#5265)
              
              
                ctlai95 e314c12
              
                telemetry(AmazonQ) ProgrammingLanguage is unknown (#5267)
              
              
                Randall-Jiang bc0ed7b
              
                Updating version to 3.48
              
              
                 fab42e9
              
                Updating SNAPSHOT version to 3.49-SNAPSHOT
              
              
                 f9473c4
              
                feat(feature dev): Add setting to allow Q to run code and test comman…
              
              
                willyyhuang f495d7d
              
                Exclude gradle-wrapper.jar from .gitignore checks
              
              
                karanA-aws 240cc27
              
                Exclude gradle-wrapper.jar from .gitignore checks
              
              
                karanA-aws 1a324bb
              
                merge test for gradlle-wrapper.jar file dismissal from .gitignore.
              
              
                karanA-aws 8b52b85
              
                merge test for gradlle-wrapper.jar file dismissal from .gitignore.
              
              
                karanA-aws 4ffc179
              
                resolved rebase conflicts.
              
              
                karanA-aws File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| 
          
            
          
           | 
    @@ -112,6 +112,11 @@ class FeatureDevSessionContext(val project: Project, val maxProjectSizeBytes: Lo | |
| suspend fun ignoreFile(file: VirtualFile): Boolean = ignoreFile(file.path) | ||
| 
     | 
||
| suspend fun ignoreFile(path: String): Boolean { | ||
| // explicitly allow the Gradle wrapper JAR file | ||
| if (path.endsWith("gradle/wrapper/gradle-wrapper.jar")) { | ||
                
       | 
||
| return false | ||
| } | ||
| 
     | 
||
| // this method reads like something a JS dev would write and doesn't do what the author thinks | ||
| val deferredResults = ignorePatternsWithGitIgnore.map { pattern -> | ||
| withContext(coroutineContext) { | ||
| 
          
            
          
           | 
    ||
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't change other teams test unless necassary. Change the tests for our team instead.
FeatureDevSessionContextTest.kt::testZipProject