-
Notifications
You must be signed in to change notification settings - Fork 274
fix(amazonq): fix for /test project payload collection filter #5305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rli
reviewed
Jan 28, 2025
...ty/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/GitIgnoreFilteringUtil.kt
Show resolved
Hide resolved
...software/aws/toolkits/jetbrains/services/codewhisperer/codetest/CodeTestSessionConfigTest.kt
Show resolved
Hide resolved
...software/aws/toolkits/jetbrains/services/codewhisperer/codetest/CodeTestSessionConfigTest.kt
Show resolved
Hide resolved
...software/aws/toolkits/jetbrains/services/codewhisperer/codetest/CodeTestSessionConfigTest.kt
Outdated
Show resolved
Hide resolved
...software/aws/toolkits/jetbrains/services/codewhisperer/codetest/CodeTestSessionConfigTest.kt
Outdated
Show resolved
Hide resolved
...ty/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/GitIgnoreFilteringUtil.kt
Show resolved
Hide resolved
rli
approved these changes
Jan 28, 2025
chungjac
approved these changes
Jan 28, 2025
...ty/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/GitIgnoreFilteringUtil.kt
Fixed
Show fixed
Hide fixed
...ty/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/GitIgnoreFilteringUtil.kt
Fixed
Show fixed
Hide fixed
ctlai95
reviewed
Jan 28, 2025
.changes/next-release/bugfix-52963f8d-8f8e-4b53-b7dc-0ef4819b5976.json
Outdated
Show resolved
Hide resolved
…976.json Co-authored-by: Tai Lai <[email protected]>
ctlai95
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
For both the /test and /review agents, we parse files by looping through each module to ensure all files from the project/workspace are included. The current common utility, FeatureDevSessionContext, is focused on loading the .gitignore file from the project root. While this works in most cases, for internal Amazon workspaces with multiple packages loaded into the same workspace, the .gitignore files are not being loaded to filter out irrelevant files.
Even the default patterns in the utility are not working because each file is checked for the relative path from the project root, which is derived from IntelliJ's utility function guessProjectDir(). This function may provide one of the modules as the root, but that is not always the case, causing the relative path check to fail.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.