fix(amazonq): Adding backoff and retry for export result archive streaming API. #5320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laileni-aws
reviewed
Feb 3, 2025
| return byteBufferList | ||
| } | ||
|
|
||
| /** |
Contributor
There was a problem hiding this comment.
nit: If possible we can move this to a shared place.
Contributor
Author
There was a problem hiding this comment.
Felt it was alright to keep it here in AmazonQStreamingClient class. Assuming that any other streaming APIs will be added here.
Contributor
There was a problem hiding this comment.
isn't this the same idea as 5470418#diff-b08b1d5a6c68d78f0cdb5d0ff07528a20d2d60156313fd4c4f1a41b69e2a4f36R212
Contributor
Author
There was a problem hiding this comment.
this streaming API is a suspend function. tried using a common function for both but way to many conflicts
Contributor
There was a problem hiding this comment.
you can have a thin wrapper for the non-suspending use case instead of duplicating the logic
laileni-aws
approved these changes
Feb 3, 2025
ntarakad-aws
approved these changes
Feb 3, 2025
rli
reviewed
Feb 4, 2025
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/clients/AmazonQStreamingClient.kt
Outdated
Show resolved
Hide resolved
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/clients/AmazonQStreamingClient.kt
Outdated
Show resolved
Hide resolved
rli
reviewed
Feb 4, 2025
...unity/src/software/aws/toolkits/jetbrains/services/amazonq/clients/AmazonQStreamingClient.kt
Outdated
Show resolved
Hide resolved
rli
approved these changes
Feb 5, 2025
KevinDing1
pushed a commit
to KevinDing1/aws-toolkit-jetbrains
that referenced
this pull request
Feb 6, 2025
…aming API. (aws#5320) * Adding backoff and retry for export result archive.
gandhi-21
pushed a commit
to gandhi-21/aws-toolkit-jetbrains
that referenced
this pull request
Feb 26, 2025
…aming API. (aws#5320) * Adding backoff and retry for export result archive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
We have seen rise of the ExportResultArchive API failures to 15 per week, with retryable error messages.
Adding backoff and retry to mitigate these errors.
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.