Skip to content

build: fix 251 build failure from resolving ui-tests-starter dependencies #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025
Merged

build: fix 251 build failure from resolving ui-tests-starter dependencies #5329

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a4e8f84
build: fix 251 build failure from resolving ui-tests-starter dependen…
rli Feb 5, 2025
a9d6f93
revert
rli Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ui-tests-starter/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
id("toolkit-kotlin-conventions")
id("toolkit-intellij-plugin")

id("org.jetbrains.intellij.platform")
id("org.jetbrains.intellij.platform.base")
}

val ideProfile = IdeVersions.ideProfile(project)
Expand All @@ -30,12 +30,11 @@ intellijPlatform {
val testPlugins by configurations.registering

dependencies {
testImplementation(platform("com.jetbrains.intellij.tools:ide-starter-squashed"))
// should really be set by the BOM, but too much work to figure out right now
testImplementation("org.kodein.di:kodein-di-jvm:7.20.2")
intellijPlatform {
intellijIdeaCommunity(IdeVersions.ideProfile(providers).map { it.name })

// shouldn't be needed? but IsolationException
intellijIdeaCommunity(ideProfile.community.sdkVersion)
testFramework(TestFrameworkType.Starter)
}

Expand Down
Loading