refactor(Q tech debt): make cwsprClientAdapr stateless and obtain sdk client from AwsClientManager #5331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will-ShaoHua
changed the title
Will-ShaoHua
changed the title
Will-ShaoHua
changed the title
rli
reviewed
Feb 11, 2025
| myBearerClient = getBearerClient() | ||
| return myBearerClient as CodeWhispererRuntimeClient | ||
| } | ||
| private fun bearerClient(): CodeWhispererRuntimeClient = project.awsClient() |
There was a problem hiding this comment.
i think for safety this still needs to go through connection manager
|
not needed for 2/13 release |
rli
approved these changes
Feb 14, 2025
andrewyuq
approved these changes
Feb 14, 2025
Will-ShaoHua
changed the title
Will-ShaoHua
changed the title
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-jetbrains
that referenced
this pull request
Feb 18, 2025
2 tasks
Will-ShaoHua
added a commit
to Will-ShaoHua/aws-toolkit-jetbrains
that referenced
this pull request
Mar 18, 2025
Will-ShaoHua
added a commit
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is no need to store a client as a state within this class, AwsClientManager already handle the connection change
resolve comments #5290 (comment)
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.