telemetry(amazonq) add feedback functionality with thumbs up/down #5336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Randall-Jiang
force-pushed
the
thumb-up-and-down
branch
from
91c3689 to
65fae8c
Compare
Randall-Jiang
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...oftware/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt
Fixed
Show fixed
Hide fixed
rli
reviewed
Feb 11, 2025
package-lock.json
Outdated
laileni-aws
reviewed
Feb 11, 2025
| userComment = message.comment.orEmpty(), | ||
| reason = message.selectedOption, | ||
| type = "testgen-chat-answer-feedback", | ||
| messageId = "" |
There was a problem hiding this comment.
Can we remove this messageId = "" code
laileni-aws
reviewed
Feb 11, 2025
| sentiment = Sentiment.NEGATIVE, | ||
| comment = objectMapper.writeValueAsString(comment), | ||
| ) | ||
| LOG.info { "${software.aws.toolkits.jetbrains.services.amazonqFeatureDev.FEATURE_NAME} answer feedback sent: \"Negative\"" } |
There was a problem hiding this comment.
Can you change the log text to something like this instead of amazonqFeatureDev
software.aws.toolkits.jetbrains.services.amazonqCodeTest.FEATURE_NAME
laileni-aws
reviewed
Feb 11, 2025
| @JsonProperty("tabID") val tabId: String, | ||
| val selectedOption: String, | ||
| val comment: String?, | ||
| val messageId: String, |
There was a problem hiding this comment.
I do not think we need messageId
Randall-Jiang
force-pushed
the
thumb-up-and-down
branch
from
b2a8559 to
fac3471
Compare
laileni-aws
reviewed
Feb 12, 2025
| interactionType = InteractionType.Upvote, | ||
| credentialStartUrl = getStartUrl(project = context.project), | ||
| amazonqConversationId = session.startTestGenerationRequestId | ||
|
|
laileni-aws
reviewed
Feb 12, 2025
| onChatItemVoted = (tabId: string, messageId: string, vote: string): void | undefined => { | ||
| this.sendMessageToExtension({ | ||
| tabID: tabId, | ||
| messageId: messageId, |
There was a problem hiding this comment.
Do we need messageId here?
laileni-aws
approved these changes
Feb 12, 2025
...oftware/aws/toolkits/jetbrains/services/amazonqCodeTest/controller/CodeTestChatController.kt
Fixed
Show fixed
Hide fixed
...ns-community/src/software/aws/toolkits/jetbrains/services/amazonqCodeTest/CodeTestChatApp.kt
Fixed
Show fixed
Hide fixed
Randall-Jiang
force-pushed
the
thumb-up-and-down
branch
2 times, most recently
from
fac3471 to
f1bb12c
Compare
Randall-Jiang
force-pushed
the
thumb-up-and-down
branch
from
bd617be to
b222313
Compare
|
/retryBuilds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, UTG did not have telemetry to collect user feedback on generated unit tests. This PR introduces telemetry support to address that gap. Additionally, it enables users to submit comments, which will be routed to a private SIM folder.
THUMB
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.