Skip to content

Conversation

@chungjac
Copy link
Contributor

@chungjac chungjac commented Feb 7, 2025

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

There is no syntax highlighting when viewing a diff for generated unit tests for java and python files. A user will now see syntax highlighting. See reference photos below.

Before (java and python):

java before python before

After (java and python):

java after python after

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@chungjac chungjac requested review from a team as code owners February 7, 2025 00:07
@chungjac chungjac marked this pull request as draft February 7, 2025 01:09
@chungjac chungjac marked this pull request as ready for review February 7, 2025 21:06
@@ -0,0 +1,4 @@
{
"type" : "bugfix",
"description" : "/test syntax highlighting when viewing diff"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description" : "/test syntax highlighting when viewing diff"
"description" : "Enable syntax highlighting when viewing diff for /test"

@chungjac chungjac merged commit 18590f8 into aws:main Feb 11, 2025
11 of 13 checks passed
samgst-amazon pushed a commit that referenced this pull request Feb 12, 2025
…ted unit tests (#5337)

* enable syntax highlighting when viewing diff for generated unit tests

changelog

remove unused import

* lint

* virtualFile always created and will not be null

* use session.testFileName instead of extension

* lint

* create temporary virtual file

* comment

* Update bugfix-3b7843b4-9673-4afa-90e8-7c4278f0d0fe.json
gandhi-21 pushed a commit to gandhi-21/aws-toolkit-jetbrains that referenced this pull request Feb 26, 2025
…ted unit tests (aws#5337)

* enable syntax highlighting when viewing diff for generated unit tests

changelog

remove unused import

* lint

* virtualFile always created and will not be null

* use session.testFileName instead of extension

* lint

* create temporary virtual file

* comment

* Update bugfix-3b7843b4-9673-4afa-90e8-7c4278f0d0fe.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants