Skip to content

Fix semaphore not updated in pair could make Q unusable #5341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2025
Merged

Fix semaphore not updated in pair could make Q unusable #5341

merged 4 commits into from
Feb 7, 2025

Conversation

@andrewyuq
Copy link
Contributor

@andrewyuq andrewyuq commented Feb 7, 2025

Aiming to fix the fallout of #5319

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@andrewyuq andrewyuq requested a review from a team as a code owner February 7, 2025 18:10
@andrewyuq andrewyuq requested a review from rli February 7, 2025 18:10
@andrewyuq andrewyuq enabled auto-merge (squash) February 7, 2025 18:55
@andrewyuq andrewyuq disabled auto-merge February 7, 2025 19:11
@rli
Copy link
Contributor

rli commented Feb 7, 2025

#5339

@andrewyuq andrewyuq enabled auto-merge (squash) February 7, 2025 19:51
@andrewyuq andrewyuq merged commit e3cfc8c into aws:main Feb 7, 2025
11 of 13 checks passed
andrewyuq added a commit to andrewyuq/aws-toolkit-jetbrains that referenced this pull request Feb 7, 2025
@andrewyuq
added change log for fix aws#5341
713602b
samgst-amazon pushed a commit that referenced this pull request Feb 7, 2025
@andrewyuq
added change log for fix #5341 (#5344)
489bb4a
andrewyuq added a commit to andrewyuq/aws-toolkit-jetbrains that referenced this pull request Feb 10, 2025
@andrewyuq
Revert "Fix semaphore not updated in pair could make Q unusable (aws#…
cf9dbe9 
…5341)"

This reverts commit e3cfc8c.
gandhi-21 pushed a commit to gandhi-21/aws-toolkit-jetbrains that referenced this pull request Feb 26, 2025
@andrewyuq
Fix semaphore not updated in pair could make Q unusable (aws#5341)
cdba755 
* Fix semaphore not updated in pair could make Q unusable

* detekt

* remove previous listener when states are updated
gandhi-21 pushed a commit to gandhi-21/aws-toolkit-jetbrains that referenced this pull request Feb 26, 2025
@andrewyuq
added change log for fix aws#5341 (aws#5344)
d834d36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rli rli rli approved these changes

@Will-ShaoHua Will-ShaoHua Will-ShaoHua approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewyuq @rli @Will-ShaoHua