config(amazonq): customization override should respect users' selection

[evanliu048]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Description

Previously, once a user manually selected a customization, the logic always returned the selected value, preventing fallback to the server-provided configuration. This update ensures that users can revert to the default customization if they clear their selection.

Introduced refreshDefaultCustomizationArn() to update the default customization ARN when the server-pushed configuration changes.
If the new customization differs from the stored serviceDefaultArn, it updates the ARN and switches the customization accordingly.
This ensures that users who wish to revert to the server-pushed customization can do so when appropriate.

Checklist

• My code follows the code style of this project
• I have added tests to cover my changes
• A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
• I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

[Will-ShaoHua]

Easier to handle custom override in featureConfigService.kt. All you need is to callModelConfigurator.getInstance().switchCustomization() with the one provided by featureConfig api.

FeatureConfigService.fetchFeatureConfigs is auto invoked on project startup, so you don't need to refresh manually on every caller, i.e. you just need to determine if override is needed on invocation of fetchFeatureConfig

[Will-ShaoHua]

flow is

1. on project start -> QStartupActivity -> FeatureConfigService.fetchFeatureConfig
2. if customization override is present && override arn is a new compared to previous -> ModelConfigurator.switchCustomization()

[evanliu048]

Easier to handle custom override in featureConfigService.kt. All you need is to callModelConfigurator.getInstance().switchCustomization() with the one provided by featureConfig api.
FeatureConfigService.fetchFeatureConfigs is auto invoked on project startup, so you don't need to refresh manually on every caller, i.e. you just need to determine if override is needed on invocation of fetchFeatureConfig

I attempted to call ModelConfigurator.getInstance().switchCustomization() in featureConfigService.kt, but IDEA warns that this may lead to a circular dependency. Would appreciate any suggestions on how to handle this.

[Will-ShaoHua]

I attempted to call ModelConfigurator.getInstance().switchCustomization() in featureConfigService.kt, but IDEA warns that this may lead to a circular dependency. Would appreciate any suggestions on how to handle this.

ok isee, try this instead.

class CodeWhispererProjectStartupActivity : StartupActivity.DumbAware { 

         override fun runActivity(project: Project) {
                   val customOverride = featureConfigService.getCustomOverride()
                   modelConfigurator.switchCustom(customOverride, isOverride = true)

where

class ModelConfigurator {
      fun switchCustom(val custom, isOverride = false) {
                // add logics to handle override
       }
}

[Will-ShaoHua]

something like this https://github.com/aws/aws-toolkit-vscode/pull/6545/files#diff-6c6c0bf94caada8c0edd30f9fc9fa0d254f2ff36ffb66b2898bf3ae4c07ad0acR126

[Will-ShaoHua]

FAILURE: Build failed with an exception.

• What went wrong:
  Execution failed for task ':plugin-amazonq:codewhisperer:jetbrains-community:detekt'.

Analysis failed with 13 weighted issues.

[rli]

might be trying to shove too much logic into this method

[Will-ShaoHua]

yea, originally my plan was to simply call switchCustomization within featureConfigService, but there is dependency issue as modelConfigurator is still in codewhisperer package.

[Will-ShaoHua]

think i sohuld move modelConfig to shared/ then we can remove this

[Will-ShaoHua]

/retryBuilds