Skip to content

fix(chat telemetry): fix infinite service call of sendUserModification on failure #5350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

fix(chat telemetry): fix infinite service call of sendUserModification on failure #5350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ...olkits/jetbrains/services/codewhisperer/telemetry/CodeWhispererUserModificationTracker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo
}

private fun emitTelemetryOnChatCodeInsert(insertedCode: InsertedCodeModificationEntry) {
try {
val modificationPercentage = try {
val file = insertedCode.vFile
if (file == null || (!file.isValid)) throw Exception("Record OnChatCodeInsert - invalid file")

Expand All @@ -145,11 +145,12 @@ class CodeWhispererUserModificationTracker(private val project: Project) : Dispo
val currentString = document?.getText(
TextRange(insertedCode.range.startOffset, insertedCode.range.endOffset)
)
val modificationPercentage = checkDiff(currentString?.trim(), insertedCode.originalString.trim())
sendModificationWithChatTelemetry(insertedCode, modificationPercentage)
checkDiff(currentString?.trim(), insertedCode.originalString.trim())
} catch (e: Exception) {
sendModificationWithChatTelemetry(insertedCode, null)
null
}

sendModificationWithChatTelemetry(insertedCode, modificationPercentage)
}

private fun emitTelemetryOnSuggestion(acceptedSuggestion: AcceptedSuggestionEntry) {
Expand Down
Loading