-
Notifications
You must be signed in to change notification settings - Fork 275
feat(q): stub out Q LSP logic #5352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Qodana Community for JVM4 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
| showMessage(message) | ||
| } | ||
|
|
||
| override fun getConnectionMetadata() = CompletableFuture.completedFuture( |
Check notice
Code scanning / QDJVMC
Function or property has platform type Note
...-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageServer.kt
Fixed
Show fixed
Hide fixed
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Fixed
Show fixed
Hide fixed
...ws/toolkits/jetbrains/services/amazonq/lsp/model/aws/credentials/UpdateCredentialsPayload.kt
Fixed
Show fixed
Hide fixed
...ains-community/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLspService.kt
Fixed
Show fixed
Hide fixed
| } | ||
|
|
||
| @Service(Service.Level.PROJECT) | ||
| class AmazonQLspService(project: Project, private val cs: CoroutineScope) : Disposable { |
Check warning
Code scanning / QDJVMC
Unused symbol Warning
| } | ||
|
|
||
| @Service(Service.Level.PROJECT) | ||
| class AmazonQLspService(project: Project, private val cs: CoroutineScope) : Disposable { |
Check warning
Code scanning / QDJVMC
Constructor parameter is never used as a property Warning
| */ | ||
| class AmazonQLanguageClientImpl : AmazonQLanguageClient { | ||
| override fun telemetryEvent(`object`: Any) { | ||
| println(`object`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: not needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we're going to keep the prints until they are implemented properly
|
|
||
| package software.aws.toolkits.jetbrains.services.amazonq.lsp | ||
|
|
||
| import com.google.gson.ToNumberPolicy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be using gson?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes lsp4j only works with gson
| }.traceMessages( | ||
| PrintWriter( | ||
| object : StringWriter() { | ||
| private val traceLogger = LOG.atLevel(if (isDeveloperMode()) Level.INFO else Level.DEBUG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh this is a good idea, maybe we can convert this to a util?
| } | ||
|
|
||
| @Service(Service.Level.PROJECT) | ||
| class AmazonQLspService(project: Project, private val cs: CoroutineScope) : Disposable { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How would this be triggered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
future pr
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Show resolved
Hide resolved
...munity/src/software/aws/toolkits/jetbrains/services/amazonq/lsp/AmazonQLanguageClientImpl.kt
Show resolved
Hide resolved
This is the initial iteration of the bare minimum of process management to interact with Amazon Q logic vended by Flare. It is a direct port of the exploratory work done in https://github.com/rli/lsp-exp/tree/master/src/main/kotlin/org/example/lsp4j Missing are tests and any sort of edge case handling
This is the initial iteration of the bare minimum of process management to interact with Amazon Q logic vended by Flare. It is a direct port of the exploratory work done in https://github.com/rli/lsp-exp/tree/master/src/main/kotlin/org/example/lsp4j Missing are tests and any sort of edge case handling
This is the initial iteration of the bare minimum of process management to interact with Amazon Q logic vended by Flare.
It is a direct port of the exploratory work done in https://github.com/rli/lsp-exp/tree/master/src/main/kotlin/org/example/lsp4j
Missing are tests and any sort of edge case handling
Types of changes
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.